Date: Thu, 24 Jul 1997 21:39:05 -0700 From: David Greenman <dg@root.com> To: itojun@itojun.org Cc: hackers@freebsd.org Subject: Re: odd xxget() in some network drivers Message-ID: <199707250439.VAA16721@implode.root.com> In-Reply-To: Your message of "Fri, 25 Jul 1997 13:30:53 %2B0900." <18562.869805053@itojun.csl.sony.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
>> The new logic in that PR is:
>> ! if (MHLEN < len) {
>> The only problem with the above is that the first if () expression is wrong.
>>The test should be if (len > MHLEN). Not only is this correct for style, but
>>it is logically different: MHLEN < len will allocate an mbuf cluster when
>>len == MHLEN, and this is not desired.
>
> ???? I did not write MHLEN <= len. Why len>MHLEN and MHLEN<len
> should result in different situation?
Sorry, brain fart. You're correct...there's a reason why we write it the
other way: so people like me don't get confused. :-)
>> I would prefer that you had your proposed changes reviewed first.
>
> I prefer that too, however only very few people seems to check
> problem reports in a regular basis... I do need to wait almost
> forever. <sigh>
In this case it's better to contact the author of the driver(s) directly.
Non-bug reports are easily ignored otherwise.
-DG
David Greenman
Core-team/Principal Architect, The FreeBSD Project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199707250439.VAA16721>