Date: Mon, 01 Sep 1997 12:17:59 -0700 From: Jim Mattson <jmattson@wco.com> To: freebsd-hackers@freebsd.org Subject: Patch for small annoyance in st driver Message-ID: <199709011918.MAA00247@denali.campbell.ca.us>
next in thread | raw e-mail | index | archive | help
With 2.2.2-RELEASE, I get the following error on every open of my tape
device:
st0(ahc0:4:0): ILLEGAL REQUEST asc:20,0 Invalid command operation code
I've tracked this down to the call to scsi_prevent() in st_open().
Given the pre-existing comment, the following change seems justified.
(Oh, and it gets rid of the annoying message too!)
*** st.c 1997/09/01 18:39:49 1.1
--- st.c 1997/09/01 18:58:17
***************
*** 433,439 ****
if ((flags & O_ACCMODE) == FWRITE)
st->flags |= ST_WRITTEN;
! scsi_prevent(sc_link, PR_PREVENT, 0); /* who cares if it fails? */
SC_DEBUG(sc_link, SDEV_DB2, ("Open complete\n"));
--- 433,439 ----
if ((flags & O_ACCMODE) == FWRITE)
st->flags |= ST_WRITTEN;
! scsi_prevent(sc_link, PR_PREVENT, SCSI_SILENT | SCSI_ERR_OK); /* who cares if it fails? */
SC_DEBUG(sc_link, SDEV_DB2, ("Open complete\n"));
[The line is the same in FreeBSD-current.]
Thanks,
--jim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709011918.MAA00247>