Date: Mon, 10 Nov 1997 20:07:34 +0100 From: Gary Jennejohn <garyj@peedub.muc.de> To: asami@cs.berkeley.edu (Satoshi Asami) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG Subject: Re: cvs commit: ports/editors/xemacs20 Makefile ports/editors/xemacs20/pkg PLIST Message-ID: <199711101907.UAA15019@peedub.muc.de> In-Reply-To: Your message of "Sun, 09 Nov 1997 15:17:42 PST." <199711092317.PAA08414@bubble.didi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Satoshi Asami writes:
> * Also simplfy removal of some directories with pkg_delete. Previously,
> * the contents of ${PREFIX}/{lib,share}/xemacs/site-lisp was deleted and
> * then the directories themselves using @dirrm. This didn't work in my
> * tests, so I changed it to just ``@exec rm -rf'' the directories.
>
>Do you really want to do that? The user may be upgrading from one
>version to another by doing pkg_delete of the original package first.
>We don't want to delete all the site-lisp stuff the user may have
>installed.
>
>IMO, a simple @dirrm without anything about the files inside should be
>fine. Any warnings can be safely ignored.
>
Upon reconsideration, probably not. Luckily, it turns out that the change
doesn't work :-) Seems that the "@unexec rm -rf" has to have a %D in it,
else the directories aren't removed. Why that is, I don't know, since an
explicit "@cwd ${PREFIX}" is done by pkg_delete.
The old PLIST explicitly removed all files in these directories and then
did @dirrm to delete the (supposedly) empty directories. It would probably
be more desirable to just leave these directories untouched if pkg_delete
is invoked, i.e. remove the @unexec's affecting these directories.
Comments ?
---
Gary Jennejohn
Home - garyj@muc.de
Work - garyj@fkr.dec.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199711101907.UAA15019>