Date: 23 Jul 1998 14:02:50 -0000 From: Jos.Backus@nl.origin-it.com To: FreeBSD-gnats-submit@FreeBSD.ORG Cc: Will Deich <will@surya.caltech.edu> Subject: ports/7379: Bug in super-3.9.7 Message-ID: <19980723140250.27400.qmail@hal.mpn.cp.philips.com>
next in thread | raw e-mail | index | archive | help
>Number: 7379
>Category: ports
>Synopsis: super's command link feature doesn't work
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 23 07:10:00 PDT 1998
>Last-Modified:
>Originator: Jos Backus
>Organization:
Origin B.V., The Netherlands
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
ports/security/super, version 3.9.7, -stable or -current
>Description:
super doesn't initialize a number of auto variables. This leads
to breakage when one tries to use the command link feature.
From the manual page:
If command is a link to the super program, then typing
% command args
is equivalent to typing
% super command args
>How-To-Repeat:
bilbo:~/bin% ls -l /usr/local/bin/super
-rwxr-xr-x 1 root wheel 80410 Jul 23 15:57 /usr/local/bin/super
bilbo:~/bin% which mount
/home/jos/bin/mount
bilbo:~/bin% ls -l mount
lrwxrwxrwx 1 jos jos 20 Jul 23 15:12 mount@ -> /usr/local/bin/super
bilbo:~/bin% super mount
/dev/da0s1a on / (local)
/dev/da0s1g on /burn (local)
/dev/da0s1h on /home (local)
/dev/da1s1f on /logs (local)
/dev/da1s1e on /tmp (local)
/dev/da0s1f on /usr (local)
/dev/da0s1e on /var (local)
procfs on /proc (local)
# This doesn't work!
bilbo:~/bin% mount
mount version 3.9 patchlevel 7
Use:
mount [-d | -D] command [args]
or:
mount [-h|-H|-f|-V]
-h=help; -H=long help; -f=just-facts-help; -V=version; -d,-D=debug
or:
mount -c
-c=check syntax in super file; don't execute anything.
Super.tab file: `/usr/local/lib/super.tab'
super:: printhelp(): Unknown verbosity level 122880
bilbo:~/bin%
>Fix:
Initialize the variables:
--- super.c.orig Thu Jul 23 15:40:37 1998
+++ super.c Thu Jul 23 15:41:16 1998
@@ -534,7 +534,7 @@
char *s, *cmd, *path;
char **arglist, **envp;
extern char *error_prog;
- int iarg, givehelp, giveversion, verbosity;
+ int iarg=0, givehelp=0, giveversion=0, verbosity=0;
s = strrchr(argv[0], '/');
prog = (s && *(s+1)) ? s+1 : argv[0];
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980723140250.27400.qmail>