Date: Thu, 25 Mar 1999 08:23:27 +0100 (MET) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: bde@zeta.org.au (Bruce Evans) Cc: mike@smith.net.au, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, luigi@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Message-ID: <199903250723.IAA12325@labinfo.iet.unipi.it> In-Reply-To: <199903250917.UAA16527@godzilla.zeta.org.au> from "Bruce Evans" at Mar 25, 99 08:17:38 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> >> Come on, that's three bytes you've saved. How about some more > >> readability? Please? 8) > > > >good point. i did a better job with "opt_ipdn.h" instead of > >"opt_ip_dummynet.h"... > > Not much better. The options file for DUMMYNET should be named > "opt_dummynet.h". just in saving chars i meant... > This is easy to fix. Poorly chosen option names such as BRIDGE > and XSERVER are hard to fix, because they may be used in countless > users' config files. since you opened the discussion on option names: do you have a better name for BRIDGE ? something like NET_BRIDGE or so ? There is another thing: having to explicitly include "opt_foo.h" in all files related to "foo" opens the door to subtle bugs that might not be detected at compile time or might even cause inconsistent behaviour at run time. I understand that name space pollution issues do not leave the option of having all "opt_*" included in "opt_global.h" unless we standardize names in a way that reduces conflicts... So should we go for that, e.g. having OPT_* for generic options DEV_* for devices and so on ? thanks luigi -----------------------------------+------------------------------------- Luigi RIZZO . EMAIL: luigi@iet.unipi.it . Dip. di Ing. dell'Informazione HTTP://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903250723.IAA12325>