Date: Mon, 28 Jun 1999 19:33:11 +0200 From: Pierre Beyssac <beyssac@enst.fr> To: Dag-Erling Smorgrav <des@flood.ping.uio.no>, Pierre Beyssac <pb@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/vipw pw_util.c vipw.c Message-ID: <19990628193311.A63701@enst.fr> In-Reply-To: <xzpogi01e8n.fsf@flood.ping.uio.no>; from Dag-Erling Smorgrav on Mon, Jun 28, 1999 at 06:28:24PM %2B0200 References: <199906261215.FAA18022@freefall.freebsd.org> <xzpogi01e8n.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 28, 1999 at 06:28:24PM +0200, Dag-Erling Smorgrav wrote: > > Force umask to 077 (instead of 000) during the edit phase, to get > > Wrong fix. The correct fix is to save and restore the original umask. > See attached patch. I disagree; the umask 077 is on purpose because we're dealing with the password file, not just any random use of $EDITOR. Given that many people have a root umask set to 022, it's much safer to force umask to 077, since master.passwd (and hence any partial write of it) shouldn't EVER be world-readable. -- Pierre Beyssac pb@enst.fr To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990628193311.A63701>