Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Dec 1999 08:17:06 -0800
From:      "David O'Brien" <obrien@FreeBSD.ORG>
To:        Sheldon Hearn <sheldonh@uunet.co.za>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.sbin/chown Makefile
Message-ID:  <19991214081706.A85970@dragon.nuxi.com>
In-Reply-To: <41621.945174529@axl.noc.iafrica.com>; from sheldonh@uunet.co.za on Tue, Dec 14, 1999 at 02:28:49PM %2B0200
References:  <40554.945171891@axl.noc.iafrica.com> <41621.945174529@axl.noc.iafrica.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 14, 1999 at 02:28:49PM +0200, Sheldon Hearn wrote:
> > -	chown root.wheel "$1"
> > +	chown root.wheel "$1" || exit 1
> 
> I think the correct fix here would have been to revert that change,
> rather than shuffling binaries around unnecessarily.

That would be fine.  BUT, we should issue a warning that the device node
should be re-MAKEDEV'ed once multi-user.  Otherwise there could be a
security issue [I am not sure what the owner:group will be w/o the
`chown'].  Not erroring out, or warning the user to re-run MAKEDEV
with /usr mounted can create a bad configuration.
 
-- 
-- David    (obrien@NUXI.com)


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991214081706.A85970>