Date: Sun, 19 Dec 1999 17:18:57 +0800 From: Peter Wemm <peter@netplex.com.au> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Greg Lehey <grog@lemis.com>, FreeBSD current users <FreeBSD-current@FreeBSD.ORG> Subject: Re: Recent current hangs frequently for 1 to 2 seconds. Message-ID: <19991219091857.914021CA0@overcee.netplex.com.au> In-Reply-To: Message from Matthew Dillon <dillon@apollo.backplane.com> of "Sat, 18 Dec 1999 20:16:53 PST." <199912190416.UAA01125@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon wrote:
> :I've just upgraded to -CURRENT as of yesterday, and I'm noticing a
> :number of occasions where all activity ceases for a second or two at a
> :time; it seems to be related to IDE disk activity with the new ATA
> :driver, but I don't have much evidence. I'm running a SiS 5591
> :chipset. Has anybody else seen something like this?
> :
> :Greg
>
> It's possible that the blockages you are seeing are due to the ATA
> driver, but it's also possible that they are due to a bug in the
> buffer cache flushing code which the following patch fixes. So try
> the patch and see if that fixes your problem. If it doesn't then
> we can at least rule it out as being the cause of the problem you
> are seeing.
[..]
Just one comment.. You've replaced vfs_bio's call to speedup_syncer() with
a bufdaemon speedup.. Granted I don't understand the details here, but
I'm curious why? (or why not use both?) The reason I ask is that I wonder
whether removing of the speedup of the vnode cleanup rate is a good idea or
not.. or if the bufdaemon speedup does this as a side effect via the hooks
softupdates has got in the bio system. This is not a criticism, just a
request for enlightenment. :-)
> @@ -1571,9 +1573,8 @@
> flags = VFS_BIO_NEED_ANY;
> }
>
> - /* XXX */
> + bd_speedup(); /* heeeelp */
>
> - (void) speedup_syncer();
> needsbuffer |= flags;
> while (needsbuffer & flags) {
> if (tsleep(&needsbuffer, (PRIBIO + 4) | slpflag,
Cheers,
-Peter
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991219091857.914021CA0>