Date: Sun, 4 Aug 2013 14:59:05 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Andriy Gapon" <avg@FreeBSD.org> Cc: freebsd-arch@FreeBSD.org Subject: Re: translate INVARIANTS to DEBUG for code from OpenSolaris Message-ID: <1A44B776F5B64F7494C52060B5B9ED73@multiplay.co.uk> References: <51F67B2A.3040302@FreeBSD.org> <69CEF0CC3C8C4B9BBA8E3ACACB18DC2B@multiplay.co.uk> <51F6B5EF.5020407@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message -----
From: "Andriy Gapon" <avg@FreeBSD.org>
>> I'm not sure you need #define ZFS_DEBUG as its already a dependency on
>> DEBUG see:
>> sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_debug.h
>
> Good point. Thank you.
>
>> Should this connection be broken and INVARIANTS only trigger DEBUG by
>> default? One potential reason for this distinction is that ZFS_DEBUG brings
>> with it some potentially quite heavy weight validation such as dnode_verify.
>>
>> If so I have small list of additional fixes here that where required when
>> I tested enabling ASSERTS checking without ZFS_DEBUG.
>>
>> What do others think, should INVARIANTS trigger ZFS_DEBUG or should that
>> be kept seperate?
>
> I would prefer to follow what upstream does in this respect.
> If DEBUG implies ZFS_DEBUG upstream, then I think that we should do the same for
> INVARIANTS -> DEBUG -> ZFS_DEBUG.
> Unless there are strong reasons to do otherwise.
Been testing this today including forcing a ZFS ASSERT violation and it
all works as expected including not getting all the false positive LOR :)
Do intend to get this committed in the near future?
Regards
Steve
================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1A44B776F5B64F7494C52060B5B9ED73>