Date: Sun, 18 Dec 2011 02:53:32 +0800 From: Jan Beich <jbeich@tormail.net> To: Chris Rees <crees@freebsd.org> Cc: Christer Solskogen <christer.solskogen@gmail.com>, freebsd-ports <freebsd-ports@freebsd.org>, garga@freebsd.org Subject: Re: Removal of use_gmake breaks lua Message-ID: <1RbzOV-000AQU-65@internal.tormail.net> In-Reply-To: <CADLo83_6ALN5YyF-E9i_%2Bn8XH-qNeoAfKnYeZcqks3du7Jd8tA@mail.gmail.com> (Chris Rees's message of "Sat, 17 Dec 2011 16:47:35 %2B0000") References: <CAMVU60aj2jZK6NWWpYK=Ub2qhUU4kEdGPKxGqjLyUoSDC%2Bu3Uw@mail.gmail.com> <CADLo8382u95a1BvBZ6SGBTKPjwmCMC2b=QB7xvq31zYMfcY2jA@mail.gmail.com> <1RbxBi-0008Ls-5O@internal.tormail.net> <CADLo83_6ALN5YyF-E9i_%2Bn8XH-qNeoAfKnYeZcqks3du7Jd8tA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Chris Rees <crees@freebsd.org> writes: >> Chris Rees <crees@freebsd.org> writes: >> >>>> as seen here: >>>> http://docs.freebsd.org/cgi/getmsg.cgi?fetch=295602+0+/usr/local/www/db/text/2011/cvs-all/20111113.cvs-all >>> >>> I don't like the proposed solution; it's less hackish to just use >>> gmake again; most people have it installed anyway.... >> >> A non-hackish solution would involve fixing sys.mk to guard against >> recursive inclusion of __MAKE_CONF. bsd.port.mk is known to have >> this when using make(1) for do-build. >> >> Not that I mind shoving the issue under the carpet by using gmake. [...] > > Ah now there is a better solution :) It breaks non ports builds if the guard is propagated via .MAKEFLAGS. And one no longer can .if/.ifdef (in make.conf) innards of ports. > > I'll see if we can get it in the tree. Nevermind, in case of lang/lua 1/ sys.mk sets CFLAGS= from make.conf 2/ Makefile adds -fPIC to CFLAGS 3/ bsd.port.mk copies CFLAGS to MAKE_ENV 4/ sys.mk sets CFLAGS from make.conf again, `=' overrides CFLAGS from environment A simple make(1) build doesn't export CFLAGS # Makefile all: @cd foo && $(MAKE) @cd foo && CFLAGS='$(CFLAGS)' $(MAKE) # foo/Makefile all: @echo $(CFLAGS)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1RbzOV-000AQU-65>