Date: Sun, 17 Mar 2019 15:54:29 -0400 From: Charlie Li <ml+freebsd@vishwin.info> To: Jan Beich <jbeich@FreeBSD.org>, Graham Perrin <grahamperrin@gmail.com> Cc: gecko@freebsd.org Subject: Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro Message-ID: <1a8a2cd4-fce2-5dca-ec4a-a417d783f56a@vishwin.info> In-Reply-To: <mult-tqlp-wny@FreeBSD.org> References: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com> <mult-tqlp-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--tHcPwBBQgb86OCd4LcWvnxGyaNYNo3Ec2
Content-Type: multipart/mixed; boundary="aWC9jlW58SNAe5AQdVO8Qf7OEXLXPFvbn";
protected-headers="v1"
From: Charlie Li <ml+freebsd@vishwin.info>
To: Jan Beich <jbeich@FreeBSD.org>, Graham Perrin <grahamperrin@gmail.com>
Cc: gecko@freebsd.org
Message-ID: <1a8a2cd4-fce2-5dca-ec4a-a417d783f56a@vishwin.info>
Subject: Re: Building (deleted) Waterfox 56.2.8: error: missing documentation
for macro
References: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com>
<mult-tqlp-wny@FreeBSD.org>
In-Reply-To: <mult-tqlp-wny@FreeBSD.org>
--aWC9jlW58SNAe5AQdVO8Qf7OEXLXPFvbn
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB-large
Content-Transfer-Encoding: quoted-printable
On 17/03/2019 12:25, Jan Beich wrote:
> Graham Perrin writes:
>=20
>> error: missing documentation for macro
>> -->=20
>> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/=
style_traits/values.rs:341:1
>> |
>> 341 | macro_rules! define_css_keyword_enum {
>> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> |
>> note: lint level defined here
>> -->=20
>> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/=
style_traits/lib.rs:12:22
>> |
>> 12 | #![deny(unsafe_code, missing_docs)]
>> | ^^^^^^^^^^^^
>=20
> Looks like a regression from Rust 1.33 update.
>=20
> Either remove missing_docs from #![deny(...)] lines (or lines themselve=
s)
> for each one that triggers error (no need to bother with unused ones) o=
r
> add MOZ_OPTIONS+=3D--disable-stylo to Makefile.local.
>=20
> www/firefox-esr et al. simply backported upstream fixes for warnings to=
> avoid having to maintain workarounds forever. Rebasing those against
> very old Stylo code isn't worth the effort.
>=20
I simply followed the tip given in Mozilla bug 1521249 (remove
`#![deny(missing_docs)]`), and have been running with it since we
updated our lang/rust to 1.33:
https://bugzilla.mozilla.org/show_bug.cgi?id=3D1521249#c36
Mozilla upstream are concerned about keeping compatibility with older
rust, especially for their ESR. Since we only ship the latest version of
rust at a time, we don't have to worry about that sort of compatibility,
so backport away.
--=20
Charlie Li
=E2=80=A6nope, still don't have an exit line.
(This email address is for mailing list use; replace local-part with
vishwin for off-list communication if possible)
--aWC9jlW58SNAe5AQdVO8Qf7OEXLXPFvbn--
--tHcPwBBQgb86OCd4LcWvnxGyaNYNo3Ec2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE/3/Cqr5a+41PbEb+jnB43vIDq2wFAlyOpf0ACgkQjnB43vID
q2yRFQ/+LBE7kspQnwk9LLK9iafDLtRmpKP6BVkf2kLq4yE+DxwhMFuZNdJ61/X9
vIr7CBjVstDqXTYgk50L4lh6tdVJYoID2xUN8bxY2qGVn7KjSSW9Gx+kB+FvJlEm
xLrl7rEqWpj7bB9BY76Y1ipBqKApCFy8e3a/lxPO7ZCrwoo2wPjc2zMWnu/P64jb
3/VKdDAXClDCvYSZmE0ej8yOr1entLwEgPPbxKw9e6SWh+q9L2H3+Qe5tc+lkeQY
8Jh19Rt40nsrLgKxQxcSTf9yA4yiMgnaoWRbXV1n/ewSlqF/uRDfKTWz7+KZhKth
e09eZzhXd3ShViAM31aHTelPVkfZ4C3RsbTxbYHUWd67RxtgT9j61S7I33Qe6edk
rUcFyL0c469HmWVuu3ozd2OP6VvL0P3Tr9ipWFoDskb8F3K56HdMS9iG1HCc0hJW
gy7pWiCNy+nYhCius+Ridu1ZNHi8BlLhayrwF4fzNNw7SCRx3CActtWXDjQm3QJ6
rgVni9WIqBS8mql0s8o1ogdvQfgXF+bxGA3LrnmhIV3bxGrXBbjdINi7U8Z50Z3L
FgDgV3HLsIIxJNVmrZ7GQsJV7UknLzT7etEg1y5Zou83iy2G6ry8nC4ZfW4D0deT
l0gBg5kL+nHieFZdCo+jKLxYabzxi7BhJsD3EVs6btmXjy7xyrE=
=KHb1
-----END PGP SIGNATURE-----
--tHcPwBBQgb86OCd4LcWvnxGyaNYNo3Ec2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1a8a2cd4-fce2-5dca-ec4a-a417d783f56a>