Date: Fri, 7 Sep 2018 22:56:51 +0300 From: Yuri Pankov <yuripv@yuripv.net> To: freebsd-hackers <freebsd-hackers@freebsd.org> Subject: intelspi: fix "Device leaked IRQ resources" Message-ID: <1edec70d-8ba3-56c8-d25e-1aef9458452e@yuripv.net>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] A simple fix for an obvious typo, leading to "Device leaked IRQ resources" on attach failure or detach. [-- Attachment #2 --] diff --git a/sys/dev/intel/spi.c b/sys/dev/intel/spi.c index 9b229bb74123..575240fc3167 100644 --- a/sys/dev/intel/spi.c +++ b/sys/dev/intel/spi.c @@ -480,7 +480,7 @@ intelspi_attach(device_t dev) sc->sc_mem_rid, sc->sc_mem_res); if (sc->sc_irq_res != NULL) - bus_release_resource(dev, SYS_RES_MEMORY, + bus_release_resource(dev, SYS_RES_IRQ, sc->sc_irq_rid, sc->sc_irq_res); return (ENXIO); @@ -503,7 +503,7 @@ intelspi_detach(device_t dev) sc->sc_mem_rid, sc->sc_mem_res); if (sc->sc_irq_res != NULL) - bus_release_resource(dev, SYS_RES_MEMORY, + bus_release_resource(dev, SYS_RES_IRQ, sc->sc_irq_rid, sc->sc_irq_res); return (0);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1edec70d-8ba3-56c8-d25e-1aef9458452e>