Date: Tue, 28 Mar 2000 18:21:06 -0500 (EST) From: mi@video-collage.com To: Ade Lovett <ade@lovett.com> Cc: freebsd-ports@FreeBSD.org Subject: Re: ports/12739: New port: AT&T's DjVu Netscape plug-in Message-ID: <200003282321.SAA04202@xxx.video-collage.com> In-Reply-To: <20000328170640.M69223@lovett.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 Mar, Ade Lovett wrote: = On Tue, Mar 28, 2000 at 02:40:07PM -0800, Mikhail Teterin wrote: = > The newer version of the plugin port is at = > http://virtual-estates.net/djvu-plugin.shar = = Unfortunately, there seem to be a couple of issues here. = = First, there are a number of portlint problems.. in particular the = "@cwd /" in the PLIST is scary .. I think I'd want to rewrite things = so MOZILLA_HOME is a relative path, based on ${PREFIX}/${LOCALBASE} -- Well, if I harcode MOZILLA_HOME as ${LOCALBASE}/lib/netscape, there is no problem. But I did not want to do that... = I'd strongly recommend installing devel/portlint and using it to clean = things up before submission. I used it: OK: checking pkg/COMMENT. OK: checking pkg/DESCR. OK: checking Makefile. WARN: possible direct use of command "ln" found. use ${LN} instead. WARN: possible use of absolute pathname "/DjVu/dejavu", in Makefile. WARN: extra item placed in the *_DEPENDS section, for example, "MOZILLA_HOME". OK: checking files/md5. 0 fatal errors and 3 warnings found. I put the "TAR?=tar" and "LN?=ln" in there on purpose, because I tested this port on an old 2.2.8 machine with old bsd.port.mk. The two other warnings are bogus too -- one is there because of quotes around ${MOZILLA_HOME} (what if it has spaces in it?) and the other is because RUN_DEPENDS lists ${MOZILLA_HOME}. = Second, the post-install target, rather than having a bunch of = commented-out "read this", should actually display the license and = have the end-user accept it. You're almost certainly breaking the = terms of the license without doing this. I'm sure I'm not. With the NO_CDROM/NO_PACKAGE we are not even a party of the license agreement... This way the port is not interactive, which is good, is not it?... Uhhh, did I rebute everything? :-) -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003282321.SAA04202>