Date: Wed, 23 Aug 2000 09:36:12 +0200 (CEST) From: Luigi Rizzo <luigi@info.iet.unipi.it> To: Archie Cobbs <archie@whistle.com> Cc: Robert Watson <rwatson@FreeBSD.ORG>, Tomas Hodan <tomas@hodan.sk>, freebsd-net@FreeBSD.ORG Subject: Re: bridging and freebsd crash Message-ID: <200008230736.JAA27319@info.iet.unipi.it> In-Reply-To: <200008222039.NAA68458@bubba.whistle.com> from Archie Cobbs at "Aug 22, 2000 01:39:16 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> Robert Watson writes: > > I'm beginning to feel that we might want to revamp the current bridging > > framework, combining the best aspects of the current work with the some of > > the structural framework from the OpenBSD implementation. I haven't had > > I'll restate my suggestion: rewrite the bridging code as a netgraph node. Ok, sorry but at this point i think i need to say this on the list. People, do not take this as a personal attack as it is not. Archie- it's much simpler than that. Bridging+ipfw in 3.x did not have the problems that people is mentioning -- at least i have had quite a few of them in use for a long time now and no reports for weird crashes (i am specifically referring to the picobsd images available from my web site which is almost exactly the code in the RELENG_3 tree). The problems in 4.x/5.x are likely due to improper mbuf handling (specifically, these mbufs are shared between device drivers and in some cases upper layers in the protocol stack, which is fine but requires a bit of care in doing things, and timing is very much hardware dependent), and some code that was deleted, all of this is related to your ether_input() changes. As it told you at that time, I agreed on the change in principle (as we gain a lot in terms of reduced code bloat and more supported cards); however, doing the commit without testing that bridging was still working with all features after the change was really a bad idea -- and i also told you this. I don't want to look as the one who complains "i knew it" as i did not have the time (nor i do now, at least in the near future) to do the required testing and fix things, but, alas, i did not commit such code! Redoing things differently is not going to help if the problem is lack of time and testing. cheers luigi > The Ethernet stuff has already been modified to make it plug & play > ready, using the ng_ether(4) "upper" and "lower" hooks. Makes things > nice & self-contained that way. > > -Archie > > ___________________________________________________________________________ > Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com -----------------------------------+------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) Mobile +39-347-0373137 -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008230736.JAA27319>