Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Sep 2000 13:39:01 -0700 (PDT)
From:      John Polstra <jdp@polstra.com>
To:        current@freebsd.org
Cc:        Alexander@Leidinger.net
Subject:   Re: patch for openssh
Message-ID:  <200009172039.NAA12052@vashon.polstra.com>
In-Reply-To: <200009170929.e8H9TZn01194@Magelan.Leidinger.net>
References:  <200009170929.e8H9TZn01194@Magelan.Leidinger.net>

next in thread | previous in thread | raw e-mail | index | archive | help
In article <200009170929.e8H9TZn01194@Magelan.Leidinger.net>,
Alexander Leidinger  <Alexander@Leidinger.net> wrote:
> 
> Index: authfd.c
> ===================================================================
> RCS file: /big/FreeBSD-CVS/src/crypto/openssh/authfd.c,v
> retrieving revision 1.6
> diff -u -r1.6 authfd.c
> --- authfd.c	2000/09/10 09:35:37	1.6
> +++ authfd.c	2000/09/16 15:27:25
> @@ -178,7 +178,7 @@
>  	if (sock < 0)
>  		return NULL;
>  
> -	auth = xmalloc(sizeof(*auth));
> +	auth = xmalloc(sizeof(AuthenticationConnection));
>  	auth->fd = sock;
>  	buffer_init(&auth->identities);
>  	auth->howmany = 0;

What is the point of that change?  Functionally it makes no difference
at all, since "*auth" is an AuthenticationConnection.  It makes the
code harder to maintain in case the type of "auth" is changed in the
future.

John
-- 
  John Polstra                                               jdp@polstra.com
  John D. Polstra & Co., Inc.                        Seattle, Washington USA
  "Disappointment is a good sign of basic intelligence."  -- Chögyam Trungpa



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009172039.NAA12052>