Date: Tue, 26 Sep 2000 18:47:56 -0700 From: Mike Smith <msmith@freebsd.org> To: Mike Smith <msmith@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpi acpi.c acpi.h acpi_powerres.c Message-ID: <200009270147.e8R1luA02496@mass.osd.bsdi.com> In-Reply-To: Your message of "Tue, 26 Sep 2000 18:40:48 PDT." <200009270140.SAA01482@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> msmith 2000/09/26 18:40:47 PDT
>
> Modified files:
> sys/dev/acpi acpi.c acpi.h acpi_powerres.c
> Log:
> Shut up some debugging messages that appear to have been left on by
> default.
This and some other issues with the last couple of commits in the ACPI
code have me a little worried.
None of these should have been left enabled. The current default takes
at least one (maybe three) ACPI interrupts per keystroke, and logs them
all to the console (and syslog).
Also, acpi.c and friends have some massive style and cleanliness
problems. I'd like to take a major whitespace/style cleanup through at
least acpi.? and acpi_powerres.? soon, but I don't want to upset others
by generating huge diffs against their work.
Iwasaki-san, can you suggest a good time to do this? I'm not so worried
about the aml interpreter, but this code needs a *serious* cleanup, and
probably some more splitting out before it gets much older. I'd also
like to ask people to be a bit tidier when working around here.
Thanks.
--
... every activity meets with opposition, everyone who acts has his
rivals and unfortunately opponents also. But not because people want
to be opponents, rather because the tasks and relationships force
people to take different points of view. [Dr. Fritz Todt]
V I C T O R Y N O T V E N G E A N C E
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009270147.e8R1luA02496>