Date: Thu, 28 Sep 2000 19:04:14 -0300 From: "Mario Sergio Fujikawa Ferreira" <lioux@uol.com.br> To: freebsd-ports@freebsd.org Cc: andrew@cream.org, mi@aldan.algebra.com Subject: Re: erlang port -- a poster child (Re: I'll be rolling a 4.1.1 r Message-ID: <20000928190414.A38465@Fedaykin.here>
next in thread | raw e-mail | index | archive | help
>> Please, consider new PR-class(es) (port-update, port-maintainer) for
>> this -- that's much more formal, easier to search for and more obvious
>> for a person filling it the PR out. One person so far agreed and no one
>> objected...
>
>Right, I've left this several days to see if any GNATS-guru might appear and
>give us an opinion on getting some new PR classes added, because I know
>absolutely nothing about it.
I am no GNATS-guru. However, since this is a volunteer
effort "putting your C where your mouth is" is sometimes required
to get the wheels turning.
So, I am tossing some code ideas:
---- this is for the gnats tree
--- gnats/gnats-adm/classes.orig Mon Apr 17 13:00:27 2000
+++ gnats/gnats-adm/classes Thu Sep 28 18:34:39 2000
@@ -39,3 +39,5 @@
mistaken::Not a problem, bad PR submission.
duplicate::Duplicate of another existing PR.
wish::A wishlist request.
+port-update::Update intended to item in the ports category
+port-maintainer::Update from a port maintainer to item in the ports category
---- THIS is for the send-pr command
diff -ruN /usr/src/gnu/usr.bin/send-pr/send-pr-el.in send-pr/send-pr-el.in
--- /usr/src/gnu/usr.bin/send-pr/send-pr-el.in Thu Aug 17 13:10:18 2000
+++ send-pr/send-pr-el.in Thu Sep 28 18:29:03 2000
@@ -129,7 +129,7 @@
(defconst send-pr::fields
(` (("Category" send-pr::set-categories
(, (or (gnats::get-config "DEFAULT_CATEGORY") nil)) enum)
- ("Class" (("sw-bug") ("doc-bug") ("change-request"))
+ ("Class" (("sw-bug") ("doc-bug") ("change-request") ("port-update") ("port-maintainer"))
(, (or (gnats::get-config "DEFAULT_CONFIDENTIAL") 0)) enum)
("Confidential" (("yes") ("no"))
(, (or (gnats::get-config "DEFAULT_CONFIDENTIAL") 1)) enum)
diff -ruN /usr/src/gnu/usr.bin/send-pr/send-pr.sh send-pr/send-pr.sh
--- /usr/src/gnu/usr.bin/send-pr/send-pr.sh Thu Aug 17 13:10:18 2000
+++ send-pr/send-pr.sh Thu Sep 28 18:30:56 2000
@@ -240,7 +240,7 @@
SYNOPSIS_C='<Synopsis of the problem (one line)>'
SEVERITY_C='<[ non-critical | serious | critical ] (one line)>'
PRIORITY_C='<[ low | medium | high ] (one line)>'
-CLASS_C='<[ sw-bug | doc-bug | change-request ] (one line)>'
+CLASS_C='<[ sw-bug | doc-bug | change-request | port-update | port-maintainer ] (one line)>'
RELEASE_C='<Release number or tag (one line)>'
ENVIRONMENT_C='<Relevant environment information (multiple lines)>'
DESCRIPTION_C='<Precise description of the problem (multiple lines)>'
@@ -450,7 +450,7 @@
PATTERN=">Class:"
CLASS=`eval sed -n -e "\"/$PATTERN/$SED_CMD\"" $TEMP`
case "$CLASS" in
- ""|sw-bug|doc-bug|change-request) CNT=`expr $CNT + 1` ;;
+ ""|sw-bug|doc-bug|change-request|port-update|port-maintainer) CNT=`expr $CNT + 1` ;;
*) echo "$COMMAND: \`$CLASS' is not a valid value for \`Class'."
esac
-----
I am not sure this is the right way to do these things.
However, even if these are correct some questions already arise:
1) We are adding 2 new classes that are category specific
(this is prone to PR filling mistakes and confusion)
2) GNATS or the filling PR tools should have some sanity
checking: ports-update and port-maintainer should give some sort
of gnats-adm warning for mistaken filling; and, the filling
forms/tools shouldn't allow it.
3) We need some sort of tool (perhaps other than GNATS, I
can't judge it) that implicit allows us to use specific class/categories
combinations. From my novel_this_morning_understanding of GNATS,
this is not something it does kindly. Classes are all generic.
I guess this will lead to the same_o
gnats_substition_or_not_monthly_discussion.
On the bright side, since we have "code", it can be discussed.
Perhaps, improved (read rewritten :).
My 2 cents,
Mario Ferreira
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000928190414.A38465>