Date: Fri, 27 Oct 2000 07:34:06 -0700 From: Mike Smith <msmith@mass.osd.bsdi.com> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Bruce Evans <bde@FreeBSD.org>, Konstantin Chuguev <Konstantin.Chuguev@dante.org.uk>, Brian Somers <brian@Awfulhak.org>, kargl@apl.washington.edu, freebsd-current@FreeBSD.org Subject: Re: platform byte order macros? Message-ID: <200010271434.e9REY6F00412@mass.osd.bsdi.com> In-Reply-To: Your message of "Fri, 27 Oct 2000 16:07:25 %2B0300." <20001027160724.A29559@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, Oct 27, 2000 at 09:49:57PM +1100, Bruce Evans wrote:
> [...]
> >
> > NetBSD supports the ntohl family on constants, but only on some arches
> > (at least in last year's version). It takes fancier macros to support
> > constants. This gives an excuse to change the inline functions back to
> > macros :-).
> >
> Cool! My upcoming byte-swapping changes to IPv4 code would benefit from
> having these macros. Could you please review the attached patch (it was
> obtained from NetBSD)?
...
> +#ifdef __OPTIMIZE__
Using macros does not "optimise" anything, and this is a very poor choice
of defines. __MACRO_ENDIAN_CONVERSIONS might be better.
--
... every activity meets with opposition, everyone who acts has his
rivals and unfortunately opponents also. But not because people want
to be opponents, rather because the tasks and relationships force
people to take different points of view. [Dr. Fritz Todt]
V I C T O R Y N O T V E N G E A N C E
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010271434.e9REY6F00412>