Date: Tue, 13 Feb 2001 02:20:53 -0200 From: "Mario Sergio Fujikawa Ferreira" <lioux@uol.com.br> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/graphics/avifile Makefile distinfo pkg-plist Message-ID: <20010213022053.A3912@Fedaykin.here> In-Reply-To: <200102130352.f1D3qE953186@vic.sabbo.net>; from sobomax@FreeBSD.org on Tue, Feb 13, 2001 at 05:51:47AM %2B0200 References: <200102130238.f1D2cCa94261@freefall.freebsd.org> <200102130352.f1D3qE953186@vic.sabbo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> Please considring attached patch.
Thanks for the prompt patch. A doubt, though, before I move.
Why is the following not working? This surely looks fine. Why is
${PORTSDIR} not being expanded correctly?
The only thing broken there is the CODEC_PORT var due to PORTSDIR
not being expanded. Why?
As per the CODEC_DETECTION_FILE, I do believe it is a bikeshed
though both are not isomorph. Just check mail/qmail-ldap for an
example where using the second form brakes it. But I can appreciate
that it is more aestheticaly pleasant. I can use the second. I was
just wondering why it is better. I am just clueless as to why,
this is not cinicism.
Content-Description: ASCII text
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/ports/graphics/avifile/Makefile,v
> retrieving revision 1.10
> diff -d -u -r1.10 Makefile
> --- Makefile 2001/02/13 02:38:12 1.10
> +++ Makefile 2001/02/13 03:51:34
> @@ -38,9 +38,8 @@
>
> FMT= /usr/bin/fmt
>
> -CODEC_PORT= ${PORTSDIR}/graphics/win32-codecs
> -#CODEC_PORT= ../win32-codecs
> -CODEC_DETECTION_FILE!= cd ${CODEC_PORT} && ${MAKE} -V CODEC_DETECTION_FILE
> +CODEC_PORT= ${.CURDIR}/../../graphics/win32-codecs
> +CODEC_DETECTION_FILE!= ${MAKE} -f ${CODEC_PORT}/Makefile -V CODEC_DETECTION_FILE
>
> LIB_VERSION= 0
> # Adhoc fix. First part.
Thanks,
--
Mario S F Ferreira - UnB - Brazil - "I guess this is a signature."
lioux at ( freebsd dot org | linf dot unb dot br )
flames to beloved devnull@someotherworldbeloworabove.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010213022053.A3912>