Date: Fri, 16 Feb 2001 01:04:51 -0700 From: Warner Losh <imp@harmony.village.org> To: Bruce Evans <bde@zeta.org.au> Cc: "Brian F. Feldman" <green@FreeBSD.org>, arch@FreeBSD.org Subject: Re: The whole libc thing. Message-ID: <200102160804.f1G84qW25651@harmony.village.org> In-Reply-To: Your message of "Fri, 16 Feb 2001 18:09:25 %2B1100." <Pine.BSF.4.21.0102161801590.2563-100000@besplex.bde.org> References: <Pine.BSF.4.21.0102161801590.2563-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.21.0102161801590.2563-100000@besplex.bde.org> Bruce Evans writes: : On Thu, 15 Feb 2001, Brian F. Feldman wrote: : : > My proposition wouldn't break any binary compatibility because it would keep : > the FILE structure size the same. : : This isn't sufficient. fileno() and getc() used to be macros and/or : inline functions that knew about the internals of the struct. Right. That's why I didn't move things around at all in the end. : > The actual contents are _not_ allowed to : > be known outside of libc, so anything that gets it wrong after this change : > deserves to break in many horrible ways. We don't need a hash lookup : > because there is already a _very_ seldom-used field, _up, which can be : > absorbed for this purpose. I initially thought _cookie was better, but : : Your patch works because (hopefully) the field is so seldom used that it : wasn't used by the old macros. I don't think that _up is used in macros back to 3.2. Further back than that is not relevant since we start running out of the ELF world and 3.x wasn't stable until 3.2. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102160804.f1G84qW25651>