Date: Mon, 12 Mar 2001 14:56:22 +0000 From: j mckitrick <jcm@FreeBSD-uk.eu.org> To: Ian Dowse <iedowse@maths.tcd.ie> Cc: Alfred Perlstein <bright@wintelcom.net>, freebsd-stable@freebsd.org Subject: Re: suspend/restore with ppp connections Message-ID: <20010312145622.A87895@dogma.freebsd-uk.eu.org> In-Reply-To: <200103121440.aa97105@salmon.maths.tcd.ie>; from iedowse@maths.tcd.ie on Mon, Mar 12, 2001 at 02:40:58PM %2B0000 References: <20010312135826.F86948@dogma.freebsd-uk.eu.org> <200103121440.aa97105@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
| The problem is that the card has been reattached, so com->gone is | 0. However com->tp is NULL because the driver has not seen an open() | since attachment. It would probably be possible to add a few tests | for com->tp != NULL in a few places, but sio.c has bigger problems | in this area. It seems that a struct tty will be leaked for every | insert/removal too. There is also a missing call to the line | discipline's l_close function in the forced detach case. Now this is the kind of thing I would be interested in helping fix. But if you say sio has bigger problems, I might be in over my head. What would happen if I just added those tests for NULL? jm -- ------------------------------------------------------------------- Jonathon McKitrick -- jcm@freebsd-uk.eu.org To Microsoft: "Your tyranny I was part of, is now cracking on every side. Now your own life is in danger. Your Empire is on fire." Front 242 ------------------------------------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010312145622.A87895>