Date: Sat, 24 Mar 2001 15:46:09 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Alex Kapranoff <kapr@acm.org> Cc: ports@FreeBSD.ORG Subject: Re: Conditionalizing MACHINE_CPU checks Message-ID: <20010324154609.A42192@xor.obsecurity.org> In-Reply-To: <20010319091353.A4146@kapran.bitmcnit.bryansk.su>; from kapr@acm.org on Mon, Mar 19, 2001 at 09:13:53AM %2B0300 References: <20010319091353.A4146@kapran.bitmcnit.bryansk.su>
next in thread | previous in thread | raw e-mail | index | archive | help
--4Ckj6UjgE2iN1+kY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Mar 19, 2001 at 09:13:53AM +0300, Alex Kapranoff wrote:
> Good day to all.
>=20
> Do I really need to wrap MACHINE_CPU tests (like ${MACHINE_CPU:Mmmx})
> inside ${OSVERSION} >=3D 500018 tests?
It's also in RELENG_4 now, so you should use check for
${OSVERSION} >=3D 500018 || ( ${OSVERSION} < 500000 && ${OSVERSION} >=3D 43=
0000 )
> E.g. is it ok to do tests in this way:
>=20
> .if defined(WITH_MMX) || ${MACHINE_CPU:Mmmx}
> SRCS+=3D mmx.c
> .elif ${ARCH} =3D=3D "i386"
> @${ECHO_MSG} "You can define WITH_MMX to use MMX instructions"
> .endif
I'd prefer to keep it under an .if OSVERSION test, so it becomes
easier to just chop out the .else section when we stop supporting
systems older than ${OSVERSION} =3D=3D 430000
Kris
--4Ckj6UjgE2iN1+kY
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE6vTHBWry0BWjoQKURAhuvAJ9BPpcgJrmZ1BoHRbxhFtDEUpCaFwCeNIlL
EmnUZeFSgjJbwEqjk/O2aDk=
=rlCz
-----END PGP SIGNATURE-----
--4Ckj6UjgE2iN1+kY--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010324154609.A42192>