Date: Sat, 7 Apr 2001 17:23:48 +0930 From: Greg Lehey <grog@lemis.com> To: lecn1306@ele.etsmtl.ca Cc: freebsd-alpha@freebsd.org Subject: Re: Vinum status Message-ID: <20010407172348.A76422@wantadilla.lemis.com> In-Reply-To: <3ACB7215.F40BE906@ele.etsmtl.ca>; from nospam@ele.etsmtl.ca on Wed, Apr 04, 2001 at 03:12:21PM -0400 References: <3ACB7215.F40BE906@ele.etsmtl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, 4 April 2001 at 15:12:21 -0400, Normand Leclerc wrote:
> There has been a nice debate on dev_t structure related to
> vinum. I need vinum working. I'd like to have a status on it
> please. Is it working in the -stable branch (4.3 BETA RC2 as of
> today) or is it still bugged?
I've taken a look at the patch you supplied. It's very big, and it
tends to obfuscate the code. As others have observed, a better
solution would be to remove the dev_t from the expurgated version of
the struct. I have some code in preparation which does this, so it
really doesn't seem to make any sense to change so much code.
Try this temporary fix. It works fine on the i386; is it OK on alpha?
--- vinumvar.h 2001/03/13 02:59:43 1.32.2.2
+++ vinumvar.h 2001/04/07 07:48:34
@@ -406,7 +406,12 @@
u_int64_t sectors; /* and length in sectors */
} *freelist;
struct partinfo partinfo; /* partition information */
+/* XXX kludge until we get this struct cleaned up */
+#if _KERNEL
dev_t dev; /* device information */
+#else
+ char dev [sizeof(int *)];
+#endif
#ifdef VINUMDEBUG
char lockfilename[16]; /* name of file from which we were locked */
int lockline; /* and the line number */
Before you say "that should be sizeof(udev_t)", note that udev_t is
defined differently in userland (another thing we need to look at, I
suppose).
Greg
--
Finger grog@lemis.com for PGP public key
See complete headers for address and phone numbers
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010407172348.A76422>