Date: Sat, 19 May 2001 00:46:06 +0100 From: Nik Clayton <nik@freebsd.org> To: John Reynolds~ <jreynold@sedona.ch.intel.com> Cc: Nik Clayton <nik@freebsd.org>, doc@freebsd.org Subject: Re: Policy on image source files in the CVS tree Message-ID: <20010519004606.E1757@catkin.nothing-going-on.org> In-Reply-To: <15109.43699.126204.944263@hip186.ch.intel.com>; from jreynold@sedona.ch.intel.com on Fri, May 18, 2001 at 04:05:23PM -0700 References: <20010517122744.B3349@catkin.nothing-going-on.org> <20010517113103.A25222@Odin.AC.HMC.Edu> <200105180028.f4I0Snn05073@bmah-freebsd-0.cisco.com> <20010518013645.A8358@catkin.nothing-going-on.org> <15109.16691.817238.944467@hip186.ch.intel.com> <20010518184813.B12846@catkin.nothing-going-on.org> <15109.25794.690992.994411@hip186.ch.intel.com> <20010518224728.C1757@catkin.nothing-going-on.org> <15109.43699.126204.944263@hip186.ch.intel.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--UKNXkkdQCYZ6W5l3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 18, 2001 at 04:05:23PM -0700, John Reynolds~ wrote: >=20 > [ On Friday, May 18, Nik Clayton wrote: ] > >=20 > > D'oh. shot2png. >=20 > yeah--that looks good Nik! Though, I spotted one foobar in the code. I ju= st > saw you created a port so I betcha you already saw this and asynchronously > fixed it, but you had: >=20 > if(!strcmp(MAGIC, header)) > err(1, "Expecting '%s', read '%s'", MAGIC, header); >=20 > but I belive you meant: >=20 > if(strcmp(MAGIC, header)) > err(1, "Expecting '%s', read '%s'", MAGIC, header); >=20 > otherwise, the SCRSHOT_ header is read successfully but we bail incorrect= ly: Eh? strcmp() returns 0 if the strings match, so you have to invert the test (or, better still, write "if(strcmp(MAGIC, header) =3D=3D 0)" which I should have done). > dolphin [~]<77>% ./shot2txt < shot2.scr=20 > shot2txt: Expecting 'SCRSHOT_', read 'SCRSHOT_': Undefined error: 0 I'd expect to see that with your change, not without it. Do you get that problem with the ports? (on the offchance that the ports distfiles haven't appeared on the ftp site yet, you can get them from http://people.freebsd.org/~nik/). N --=20 FreeBSD: The Power to Serve http://www.freebsd.org/ FreeBSD Documentation Project http://www.freebsd.org/docproj/ --- 15B8 3FFC DDB4 34B0 AA5F 94B7 93A8 0764 2C37 E375 --- --UKNXkkdQCYZ6W5l3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.5 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjsFtD0ACgkQk6gHZCw343VuhgCgiYQ4Nv/s7YQkURxyqL1SX/qK daEAn13nrLOs7FzR0d1ysVp875qWMdzx =8XO1 -----END PGP SIGNATURE----- --UKNXkkdQCYZ6W5l3-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010519004606.E1757>