Date: Mon, 21 May 2001 02:31:06 -0500 From: Will Andrews <will@physics.purdue.edu> To: Peter Pentchev <roam@orbitel.bg> Cc: Joachim Strombergson <watchman@ludd.luth.se>, FreeBSD-Audit <audit@FreeBSD.ORG> Subject: Re: Patch to add nic-se to whois Message-ID: <20010521023106.S1198@casimir.physics.purdue.edu> In-Reply-To: <20010521102922.E2781@ringworld.oblivion.bg>; from roam@orbitel.bg on Mon, May 21, 2001 at 10:29:22AM %2B0300 References: <3B0841FB.188D5933@ludd.luth.se> <20010521102922.E2781@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 21, 2001 at 10:29:22AM +0300, Peter Pentchev wrote:
> Attached is a slightly modified version of your patch, which preserves
> whitespace (tabs), and follows style(9) guidelines in ordering function
> arguments (as pointed out by Will :)
Actually, no... I was saying he introduced a functional bug (but as you
pointed out, also a style(9) bug). Look at your own patch:
[...]
> - while ((ch = getopt(argc, argv, "adgh:impQrR6")) != -1) {
> + while ((ch = getopt(argc, argv, "adghi:mpQrRs6")) != -1) {
[...]
> - "usage: whois [-adgimpQrR6] [-h hostname] name ...\n");
> + "usage: whois [-adgimpQrRs6] [-h hostname] name ...\n");
For goodness sakes, people, test your patches! ;-)
--
wca
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010521023106.S1198>