Date: Sat, 26 May 2001 21:50:57 -0700 From: Dima Dorfman <dima@unixfreak.org> To: Warner Losh <imp@harmony.village.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kbdcontrol kbdcontrol.c Message-ID: <20010527045057.A800E3E30@bazooka.unixfreak.org> In-Reply-To: <200105270431.f4R4VkE51578@harmony.village.org>; from imp@harmony.village.org on "Sat, 26 May 2001 22:31:46 -0600"
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@harmony.village.org> writes: > In message <200105270403.f4R43r843630@freefall.freebsd.org> Dima Dorfman writes: > : Modified files: > : usr.sbin/kbdcontrol kbdcontrol.c > : Log: > : A la rev. 1.36, define CONS_CLRHIST here if it isn't already since > : this is a build tool, so it has to build on 4.x with the old headers. > > A better solution would be to have #ifdef CONS_CLRHIST around its > use. We couldn't do that with PASTE because keymaps would break and > disentangling that was a mess. CONS_CLRHIST isn't required to build a > correct system, so it should be ifdef'd. I agree that this is a better solution than what I committed, but I still think `kbdcontrol -L` should be factored out into another program. It seems silly that kbdcontrol can't rely on up-to-date headers like most other programs in the system. > Consider the following untested patch: If we can't/won't factor out `kbdcontrol -L`, I'll commit this. Thanks! I knew there had to be a better way than defining an ioctl in the userland :-). Dima Dorfman dima@unixfreak.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010527045057.A800E3E30>