Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Jun 2001 01:37:47 -0700
From:      "David O'Brien" <obrien@Freebsd.org>
To:        dd@Freebsd.org, cvs-committers@Freebsd.org, cvs-all@Freebsd.org
Subject:   Re: cvs commit: src/sys/kern tty_snoop.c src/sys/sys snoop.h
Message-ID:  <20010605013747.A49295@dragon.nuxi.com>
In-Reply-To: <20010605102149.C21191@sunbay.com>; from ru@FreeBSD.org on Tue, Jun 05, 2001 at 10:21:49AM %2B0300
References:  <200106050500.f5550IM88505@freefall.freebsd.org> <3B1C7DE0.FDBD0D38@DougBarton.net> <20010605102149.C21191@sunbay.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 05, 2001 at 10:21:49AM +0300, Ruslan Ermilov wrote:
> > >   Log:
> > >   Style and cosmetic cleanups.  This driver is now reasonably stlye(9)
> > >   compliant.  All the variable definitions and function names are
> > >   reasonably consistent, and the functions which should be static (i.e.,
> > >   all of them) are.  Other assorted fixes were made.  The majority of
> > >   the delta is indentation fixes.
> > 
> > 	In my ever so humble opinion it's better to do the whitespace commits
> > seperately. That makes it much easier to see the substantive changes. 
> > 
> cvs diff -w?

Regardless, it is our practice to commit style/cosmetic changes by
themselves with no functionality changes mixed in (and vice-versa).

-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010605013747.A49295>