Date: Thu, 14 Jun 2001 15:11:29 -0700 From: Dima Dorfman <dima@unixfreak.org> To: Peter Pentchev <roam@orbitel.bg> Cc: audit@FreeBSD.org Subject: Re: fstat(1) patches to recognize FIFO's Message-ID: <20010614221129.A33673E28@bazooka.unixfreak.org> In-Reply-To: <20010614134953.E837@ringworld.oblivion.bg>; from roam@orbitel.bg on "Thu, 14 Jun 2001 13:49:53 %2B0300"
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Pentchev <roam@orbitel.bg> writes:
> Index: src/usr.bin/fstat/fstat.c
> ===================================================================
> RCS file: /home/ncvs/src/usr.bin/fstat/fstat.c,v
> retrieving revision 1.31
> diff -u -r1.31 fstat.c
> --- src/usr.bin/fstat/fstat.c 2001/05/29 20:39:47 1.31
> +++ src/usr.bin/fstat/fstat.c 2001/06/14 10:48:52
> @@ -366,6 +366,13 @@
> file.f_flag);
> }
> #endif
> +#ifdef DTYPE_FIFO
> + else if (file.f_type == DTYPE_FIFO) {
> + if (checkfile == 0)
> + vtrans((struct vnode *)file.f_data, i,
> + file.f_flag);
Style bug. A second-level indent should be 4 spaces. Actually, this
file is screwed up in this respect; at a quick glance, it looks like
some of it uses 4 spaces, while some other parts indent to the opening
parenthesis like you did above. Since it's already inconsistent, I
think it's best to follow the current guideline, which is to indent 4
spaces.
Other than that, looks great!
Dima Dorfman
dima@unixfreak.org
> + }
> +#endif
> else {
> dprintf(stderr,
> "unknown file type %d for file %d of pid %d\n",
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-audit" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010614221129.A33673E28>