Date: Sat, 16 Jun 2001 23:42:54 -0600 From: Warner Losh <imp@harmony.village.org> To: doc@freebsd.org Subject: Updates to committer's guide for getting commit bits. Message-ID: <200106170542.f5H5gsV44690@harmony.village.org>
next in thread | raw e-mail | index | archive | help
Please find enclosed the first set of patches updating the commiter's
guide to reflect the current policy on obtaining one's commit.
Please review and send me comments. I'd like to commit this or have a
doc commiter commit this as soon as it is ready.
Warner
Index: article.sgml
===================================================================
RCS file: /home/imp/FreeBSD/CVS/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v
retrieving revision 1.72
diff -u -r1.72 article.sgml
--- article.sgml 2001/06/11 01:16:39 1.72
+++ article.sgml 2001/06/17 05:39:06
@@ -60,7 +60,8 @@
<row>
<entry><emphasis>Main CVS Repository Meisters</emphasis></entry>
<entry>&a.jdp; and &a.peter; as well as &a.asami; for
- <filename>ports/</filename></entry>
+ <filename>ports/</filename> and &a.nik; for
+ <filename>doc/</filename></entry>
</row>
<row>
@@ -674,6 +675,13 @@
<para>review your diffs, using
<command>cvs diff</command></para>
</listitem>
+
+ <listitem>
+ <para>if the software has a MAINTAINER, or someone else has made
+ a number of commits to the file more than anyone else, make
+ sure you have tried to have that person review your changes
+ before the commit.</para>
+ </listitem>
</itemizedlist>
<para>Also, ALWAYS specify which files to commit explicitly on
@@ -834,7 +842,8 @@
</itemizedlist>
<para>All new committers also have a mentor assigned to them for
- the first few months. Your mentor is more or less responsible for
+ the first few months. Your mentor sponsored your commit bit with
+ core. Your mentor is more or less responsible for
explaining anything which is confusing to you and is also
responsible for your actions during this initial period. If you
make a bogus commit, it is only going to embarrass your mentor
@@ -1675,7 +1684,8 @@
yourself!</para>
<para>Contact the &a.core; if you wish to take up maintainership
- of an unmaintained part of the tree.</para>
+ of an unmaintained part of the tree or if you have issues with
+ the maintainer of part of the tree.</para>
</listitem>
</orderedlist>
</sect2>
@@ -2257,4 +2267,54 @@
</qandaentry>
</qandaset>
</sect1>
+
+ <sect1 id="new.committer">
+ <para>From time to time, committers will come across new, and promising
+ people who would be able to make valuable contributions to the FreeBSD
+ project. Maybe they have posted a lot of patches. Maybe they have
+ submitted too many PRs for them to escape punishment. Maybe they
+ write well and can contribute to the documentation effort. Maybe they
+ wish to attack the ports tree. In any event, when one finds a qualified
+ new committer, one must follow a procedure to get this person's
+ commit bit.</para>
+
+ <para>If the commit bit is for src, send your request (and justification)
+ to <email>core@FreeBSD.org</email>. If the commit bit is for ports,
+ send your request to &a.asami;. If the commit bit is for doc, send
+ your request to &a.nik;. The mentor for this new person should make
+ the request. You should get an ack of your request
+ back within 24 hours. You should get resolution of your request,
+ one way or another within one week. If you fail to get these things
+ in a timely fashion, then write to core.</para>
+
+ <para>If the request is refused, a letter explaining the refusal will
+ be sent to the sponsor in the case of src commit bits. Other tree
+ may also do the same. Often times the answer of "not yet" will be
+ sent out. Mentors are encouraged to work with their applicant in such
+ a case and resubmit their request, if appropriate after a few months
+ when the concerns raised in the refusal letter have been
+ addressed.</para>
+
+ <para>If the request is granted, then the authorizing body listed above
+ needs to send a pgp signed message to admin@FreeBSD.org authorizing
+ creation of the account. Once that is done, the admin folks will request
+ information about the applicant for use in creating their account and
+ giving them credentials to log in. The mentor is expected to followup
+ with the new committer and make sure that he or she reads this document
+ and follows the first initial steps listed here.</para>
+
+ <para>If you are a doc committer, you can commit to both the src
+ and doc trees. But only to documentation in the src tree.
+ Otherwise, you should get approval from the issuing authority
+ to start making commits outside of the area for which you
+ were originally approved.</para>
+
+ <para>Any problems in this process should be reported to the authorizing
+ authority first, and then to core if they cannot be resolved. Each step
+ without a time limit explicitly listed should be considered to have a
+ 48 hour timeout on it and the mentor is responsible for following up
+ appropriately. This is a volunteer organization and sometimes action
+ items fall onto the floor and the mentor is our oversight in this
+ process.</para>
+
</article>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106170542.f5H5gsV44690>