Date: Wed, 20 Jun 2001 17:43:16 -0500 From: Alfred Perlstein <bright@sneakerz.org> To: Jordan Hubbard <jkh@osd.bsdi.com> Cc: bmilekic@technokratis.com, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lge if_lge.c src/sys/dev/nge if_nge.c src/sys/dev/vx if_vx.c src/sys/kern uipc_mbuf.c src/sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_sk.c if_vr.c if_wb.c Message-ID: <20010620174316.O4543@sneakerz.org> In-Reply-To: <20010620151043X.jkh@osd.bsdi.com>; from jkh@osd.bsdi.com on Wed, Jun 20, 2001 at 03:10:43PM -0700 References: <20010620162727.K4543@sneakerz.org> <20010620174149.A36453@technokratis.com> <20010620170145.N4543@sneakerz.org> <20010620151043X.jkh@osd.bsdi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Jordan Hubbard <jkh@osd.bsdi.com> [010620 17:11] wrote: > To be fair to Bosko, what it looks like he's saying is that there's no > reason to pass _any_ value to it since only zero is allowed and it > doesn't do anything different if you pass a difference value. That > would mean that people *can't* "rely on m_devget doing the wrong > thing" because m_devget is currently capable of doing only one thing, > regardless of what you pass to it, in any case. What is sounds like is: pre new m_devget: m_devget(off = 0,...) == m_devget(off = 15, ...) post new m_devget: m_devget(off = 0,...) != m_devget(off = 15, ...) which means that someone inadvertantly passing non-zero off will get zapped by this change. which is what I'm objecting to. if the above guess is wrong then there's really no problem, but it sure doesn't sound like i'm wrong. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010620174316.O4543>