Date: Fri, 22 Jun 2001 03:32:01 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Mike Barcroft <mike@q9media.com> Cc: Mike Heffner <mheffner@vt.edu>, phk@freebsd.org, freebsd-audit@freebsd.org Subject: Re: whois(1) patch Message-ID: <20010622033201.B506@dragon.nuxi.com> In-Reply-To: <B73C05FD.BD5%mike@q9media.com>; from mike@q9media.com on Thu, May 31, 2001 at 02:30:21PM -0400 References: <XFMail.20010530223446.mheffner@novacoxmail.com> <B73C05FD.BD5%mike@q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 31, 2001 at 02:30:21PM -0400, Mike Barcroft wrote: > > | It does the following: > > | > > | o Silence warnings and set WARNS=2 > > | o Fix two memory leaks > > | o asprint -> strdup where appropriate > > | o calloc/strcpy/strcat -> aprintf > > | o Convert to ANSI C to avoid having to prototype main() You should separate your patches into functionality and style(9). I see DES just committed this patch as is, rather than break it into two parts as our practices says it should have been. You also changed puts() to printf(). Was there a reason for making that change? -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010622033201.B506>