Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Jun 2001 12:22:30 -0500
From:      Jonathan Lemon <jlemon@flugsvamp.com>
To:        Matt Dillon <dillon@earth.backplane.com>
Cc:        Jonathan Lemon <jlemon@flugsvamp.com>, Alfred Perlstein <bright@sneakerz.org>, Mike Silbersack <silby@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, jlemon@FreeBSD.ORG, bmilekic@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_subr.c tcp_timer.c tcp_usrreq.c tcp_var.h
Message-ID:  <20010623122230.W33375@prism.flugsvamp.com>
In-Reply-To: <200106231718.f5NHIAm72921@earth.backplane.com>
References:  <200106230321.f5N3Llv09510@freefall.freebsd.org> <20010623102801.F57058@sneakerz.org> <200106231633.f5NGXqp72502@earth.backplane.com> <20010623120531.V33375@prism.flugsvamp.com> <200106231718.f5NHIAm72921@earth.backplane.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 23, 2001 at 10:18:10AM -0700, Matt Dillon wrote:
> 
> :> :
> :> :-Alfred
> :> 
> :>     I think the new way might even be faster.  If the in_pseudo() call could
> :>     be optimized, the new way would definitely be faster.  The problem with
> :
> :The in_pseudo() call _is_ optimized, at least to some point; its
> :inline assembly in sys/i386/include/in_cksum.h.
> :
> :-- 
> :Jonathan
> 
>     Ah. Hmm.  It's a toss-up.  The inline calculations are going to be
>     about the same as a (cache hit) read, so I suppose we could keep
>     in_pseudo().  The bzero() is another matter, however.

I'm not actually sure if inlining in_pseudo() is a win or not, this
probably should be measured.  The bzero() should probably be removed;
as the comment notes, it is overkill and may not be needed.  In any
case, it is just zeroing the ip strcucture; an explicit zero assignment
is probably going to be faster.
-- 
Jonathan

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010623122230.W33375>