Date: Wed, 11 Jul 2001 10:44:21 +0900 From: Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp> To: Alfred Perlstein <bright@sneakerz.org> Cc: Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp>, jake@FreeBSD.org, jhb@FreeBSD.org, current@FreeBSD.org Subject: Re: Lock of struct filedesc, file, pgrp, session and sigio Message-ID: <200107110144.f6B1iL080250@silver.carrots.uucp.r.dl.itc.u-tokyo.ac.jp> In-Reply-To: <20010709032044.B1894@sneakerz.org> References: <20010531124007.B57907@dragon.nuxi.com> <XFMail.010531125426.jhb@FreeBSD.org> <20010531130155.A58258@dragon.nuxi.com> <200106011228.f51CSvD46848@rina.r.dl.itc.u-tokyo.ac.jp> <20010602125223.J31257@dragon.nuxi.com> <200106040748.f547mUD53783@rina.r.dl.itc.u-tokyo.ac.jp> <200106181004.f5IA4VD63112@rina.r.dl.itc.u-tokyo.ac.jp> <200107020812.f628CfK44241@rina.r.dl.itc.u-tokyo.ac.jp> <20010707164249.C88962@sneakerz.org> <20010709032044.B1894@sneakerz.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 9 Jul 2001 03:20:44 -0500, Alfred Perlstein <bright@sneakerz.org> said: Alfred> I'm also quite sure that you can't call the ktrace functions with Alfred> any mutexes held so the code is doing to need some help, basically Alfred> the trick in trapsig() and postsig() is to generate the ktrace Alfred> IO after the locks have been dropped, this means somehow caching Alfred> the info sent to ktrace where it's currently called, and calling Alfred> it later with the cached info after the locks are dropped. We can cache ktrace information into struct proc and mark the existence of cache in p_traceflag. Then we send the information to ktrace upon returning from trapsignal() or CURSIG(), or in sigexit(). Another problem I noticed is bogus unlock and lock around call of machine-and-maybe-executable-format-dependent sendsig(), found in sys/*/*/machdep.c. Instead of locking curproc in sendsig() once again, we should call sendsig() with curproc locked, and release the lock only in sendsig(). -- Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp> <tanimura@FreeBSD.org> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107110144.f6B1iL080250>