Date: Thu, 02 Aug 2001 17:32:12 +0100 From: Ian Dowse <iedowse@maths.tcd.ie> To: Bruce Evans <bde@zeta.org.au> Cc: Peter Wemm <peter@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exit.c kern_sig.c Message-ID: <200108021732.aa36978@salmon.maths.tcd.ie> In-Reply-To: Your message of "Fri, 03 Aug 2001 00:45:55 %2B1000." <20010803002014.L630-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20010803002014.L630-100000@besplex.bde.org>, Bruce Evans writes: > >Doesn't it just need to call PHOLD() to hold the UPAGES in memory while it >looks at them? (PHOLD() also faults them in if necessary.) I have put together a patch that adds a new procsig flag PS_CLDSIGIGN which could be tested instead of PHOLD'ing the parent; this might save the IO involved in swapping in a parent whose SIGCHLD handler is SIG_IGN. I'm not sure if that is a worthwhile saving. Revision 1.125 of kern_sig.c also fixed an interesting but harmless bug in do_sigaction(): it got the logic reversed when dealing with SA_SIGINFO, so it read sa_handler when it should have read sa_sigaction and vice-versa (sa_sigaction and sa_handler overlay each other in a union so it is harmless). That bit could have been left intact. Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200108021732.aa36978>