Date: Thu, 16 Aug 2001 18:33:29 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Julian Elischer <julian@elischer.org> Cc: <net@FreeBSD.ORG> Subject: Re: IPV6/KAME/protosw integration cleanup Message-ID: <20010816180314.P27152-100000@besplex.bde.org> In-Reply-To: <Pine.BSF.4.21.0108151020210.12730-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> I will not be doing any changes that affect them, Though I may still add > the prototype definitions in protsw.h as that's a generally useful thing > to do. I think those are the least useful of your changes. They are certainly the most intrusive if the function typedefs are actually used. The corresponding function typedefs for the cdevsw functions are even less useful since all the cdevsw's are now static and the prototypes can't be used in function bodies (except for variants which give the args in a list like SYSCTL_HANDLER_ARGS, but don't go there). In most cases, forward declarations of the cdevsw functions aren't necessary provided we move the cdevsw data declarations after all the function bodies. I normally dislike shuffling code to avoid forward declarations, and like to forward-declare even static functions that are defined before they are used (since this gives an easy to find list of the functions and doesn't depend on the order of the function bodies), but the cdevsw data declaration already provides a lot of structure including a list of all the cdevsw functions, so I don't mind making a special case for it. It's normal to use a similar hack for modules (put DRIVER_MODULE() declarators at the end). Protosw's are still externed, so more declarations are needed, but that should change. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010816180314.P27152-100000>