Date: Sun, 19 Aug 2001 15:50:34 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: audit@FreeBSD.org Subject: Re: at(1) signal handler fix Message-ID: <20010819155034.C49129@coffee.q9media.com> In-Reply-To: <20010818235833.A36306@xor.obsecurity.org>; from kris@obsecurity.org on Sat, Aug 18, 2001 at 11:58:33PM -0700 References: <20010818235833.A36306@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway <kris@obsecurity.org> writes:
> This patch is adapted from OpenBSD..please review.
>
> Kris
>
> Index: at.c
> ===================================================================
> RCS file: /mnt/ncvs/src/usr.bin/at/at.c,v
> retrieving revision 1.19
> diff -u -r1.19 at.c
> --- at.c 2001/07/24 14:15:51 1.19
> +++ at.c 2001/08/19 06:58:02
[...]
> static void alarmc(int signo)
> {
> -/* Time out after some seconds
> - */
> - panic("file locking timed out");
> + char buf[1024];
> +
> + /* Time out after some seconds. */
> + strlcpy(buf, namep, sizeof(buf));
> + strlcat(buf, ": file locking timed out\n", sizeof(buf));
> + write(STDERR_FILENO, buf, strlen(buf));
> + if (fcreated) {
> + PRIV_START
> + unlink(atfile);
> + PRIV_END
> + }
> + _exit(EXIT_FAILURE);
> }
[...]
Why not just call sigc() after write(2)?
The other changes look okay.
Best regards,
Mike Barcroft
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010819155034.C49129>