Date: Thu, 6 Sep 2001 13:23:55 +0300 From: Peter Pentchev <roam@ringlet.net> To: markm@FreeBSD.org Cc: re@FreeBSD.org, audit@FreeBSD.org Subject: Re: bin/30357: core dump in libpam.so when parsing config file Message-ID: <20010906132355.C1477@ringworld.oblivion.bg>
next in thread | raw e-mail | index | archive | help
Hi, I can reproduce the problem, and the (trivial-looking) patch really fixes it. Would there be much harm in taking pam_misc.c off the vendor branch and fixing (*and* MFC'ing) this before 4.4 goes out? A PAM-related coredump does look kind of important to me.. G'luck, Peter -- This sentence every third, but it still comprehensible. ----- Forwarded message from Edward Counce <edward.counce@celion.com> ----- Date: Wed, 5 Sep 2001 14:33:43 -0700 (PDT) From: Edward Counce <edward.counce@celion.com> To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-1.0 Subject: bin/30357: core dump in libpam.so when parsing config file List-ID: <freebsd-bugs.FreeBSD.ORG> List-Archive: <http://docs.freebsd.org/mail/>; (Web Archive) List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions) List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs> List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs> >Number: 30357 >Category: bin >Synopsis: core dump in libpam.so when parsing config file >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 05 14:40:02 PDT 2001 >Closed-Date: >Last-Modified: >Originator: Edward Counce >Release: 4.3-RELEASE >Organization: Celion Networks, Inc. >Environment: FreeBSD ecounce 4.3-RELEASE FreeBSD 4.3-RELEASE #0: Sat Apr 21 10:54:49 GMT 2001 jkh@narf.osd.bsdi.com:/usr/src/sys/compile/GENERIC i386 >Description: While parsing the configuration file, numeric (jump) actions in the newer control flag syntax may cause a core dump. >How-To-Repeat: add to /etc/pam.conf: sshd auth [success=1 default=ignore] pam_tacplus.so >Fix: Index: pam_misc.c =================================================================== RCS file: /home/ncvs/src/contrib/libpam/libpam/pam_misc.c,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 pam_misc.c --- pam_misc.c 18 Nov 1998 01:16:19 -0000 1.1.1.1 +++ pam_misc.c 5 Sep 2001 21:16:36 -0000 @@ -278,7 +278,7 @@ } /* observe action type */ - for (act=0; act<=-_PAM_ACTION_UNDEF; ++act) { + for (act=0; act<-_PAM_ACTION_UNDEF; ++act) { len = strlen(_pam_token_actions[act]); if (!strncmp(_pam_token_actions[act], tok, len)) { act *= -1; >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message ----- End forwarded message ----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010906132355.C1477>