Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Sep 2001 11:28:42 -0400 (EDT)
From:      Joe Clarke <marcus@marcuscom.com>
To:        Christoph Sold <so@i-clue.de>
Cc:        Jordan Hubbard <jkh@freebsd.org>, <stable@freebsd.org>
Subject:   Re: Netatalk crash on RC4 (was: Re: 4.4-RC4 report [succes])
Message-ID:  <20010913111355.W4778-200000@shumai.marcuscom.com>
In-Reply-To: <3BA0BD91.30104@i-clue.de>

next in thread | previous in thread | raw e-mail | index | archive | help
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--0-1360250229-1000394922=:4778
Content-Type: TEXT/PLAIN; charset=US-ASCII

It applied for me.  Did you save it to a Windows machine that possibly
added ^M characters?  I have done some more testing, and I think it's a
winner.  Too bad the ports tree is frozen for 4.4, though :-(.

Anyway, here is the patch again.

Joe

On Thu, 13 Sep 2001, Christoph Sold wrote:

> Joe,
>
> the second patch did not apply for me. See the attached typescript.
>
> I have not yet built a port debug version, could you hint me how to do
> that, too?
>
>
> Thanks for all your help
> -Christoph Sold
>
> Joe Clarke wrote:
>
> >Jordan, here is another patch which replaces the two I sent earlier.  This
> >should fix not only the core dump problems, but the realloc/free warnings
> >as well.  This code only gets called when no atalkd.conf file exists.  If
> >you or Christoph could test this code, and let me know if it works, I will
> >add it to the port.  I've tested things here, and it works for me,
> >and passes the A and Z malloc tests.  Thanks.
> >
> >Joe
> >
> >On Wed, 12 Sep 2001, Jordan Hubbard wrote:
> >
> >>Progress!  For the record, here's what I was getting on a RELENG_4 box
> >>(as of this morning) when netatalk attempted to start up from
> >>/usr/local/etc/rc.d/netatalk.sh:
> >>
> >>katalkd in realloc(): warning: chunk is already free.
> >>atalkd in free(): warning: chunk is already free.
> >>AppleTalk not up! Check your syslog for the reason. Child died.
> >>Sep 12 16:56:44 freebsd /kernel: pid 280 (atalkd), uid 0: exited on signal 11 (core dumped)
> >>Sep 12 16:56:44 freebsd atalkd: difaddr(0.0): Can't assign requested address
> >>nbp_rgstr: Network is unreachable
> >>Can't register freebsd:netatalk@*
> >>nbp_rgstr: Network is unreachable
> >>Can't register freebsd:Workstation@*
> >>Sep 12 16:56:45 freebsd afpd[286]: Can't register freebsd:AFPServer@*
> >>
> >>I then checked /usr/local/etc/atalkd.conf and saw that it was all
> >>simply commented out examples.  I have only one interface, rl0, and
> >>according to the comments it should have been auto-discovered, but just
> >>on a lark I tried adding it to atalkd.conf to see if it had any
> >>effect.  It did!  All the core dumps have gone away.
> >>
> >>Now I'm on to my second problem.  I've put /usr (just that, on a line
> >>by itself) into /usr/local/etc/AppleVolumes.default and "usr" (but
> >>with no leading slash) shows up in the volumes menu when I go to mount
> >>it over AFP under MacOS X.  If I then select this, the server disconnects
> >>immediately and I get:
> >>
> >>afpd[pid]: dsi_stream_read(0): No such file or directory
> >>
> >>On the FreeBSD machine's console.  Could it be because it's exporting
> >>"usr" vs "/usr"?  If so, why would it do that when I used "/usr" in
> >>the AppleVolumes.default file?
> >>
>
>
>

--0-1360250229-1000394922=:4778
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=patch-aj
Content-Transfer-Encoding: BASE64
Content-ID: <20010913112842.K4778@shumai.marcuscom.com>
Content-Description: 
Content-Disposition: attachment; filename=patch-aj

LS0tIGxpYmF0YWxrL3V0aWwvZ2V0aWZhY2UuYy5vcmlnCVRodSBTZXAgMTMg
MDA6Mjg6MjEgMjAwMQ0KKysrIGxpYmF0YWxrL3V0aWwvZ2V0aWZhY2UuYwlU
aHUgU2VwIDEzIDAwOjI4OjMwIDIwMDENCkBAIC00MywxMyArNDMsNiBAQA0K
IHsNCiAgICAgLyogaWYgd2UndmUgcnVuIG91dCBvZiByb29tLCBhbGxvY2F0
ZSBzb21lIG1vcmUuIGp1c3QgcmV0dXJuDQogICAgICAqIHRoZSBwcmVzZW50
IGxpc3QgaWYgd2UgY2FuJ3QuICovDQotICAgICBpZiAoKmkgPj0gKmxlbmd0
aCkgew0KLSAgICAgIGNoYXIgKipuZXcgPSByZWFsbG9jKGxpc3QsIHNpemVv
ZihjaGFyICoqKSooKmxlbmd0aCArIElGQUNFX05VTSkpOw0KLSAgICAgICAN
Ci0gICAgICBpZiAoIW5ldykgLyoganVzdCBicmVhayBpZiB3ZSBjYW4ndCBh
bGxvY2F0ZSBhbnl0aGluZyAqLw0KLQlyZXR1cm4gLTE7DQotICAgICAgKmxl
bmd0aCArPSBJRkFDRV9OVU07DQotICAgIH0NCiAgICAgIA0KICAgICBpZiAo
KGxpc3RbKmldID0gc3RyZHVwKG5hbWUpKSA9PSBOVUxMKQ0KICAgICAgIHJl
dHVybiAtMTsNCkBAIC02MCwzMCArNTMsMzIgQEANCiB9DQogDQogDQotc3Rh
dGljIGludCBnZXRpZmFjZXMoY29uc3QgaW50IHNvY2tmZCwgY2hhciAqKmxp
c3QsIGludCAqbGVuZ3RoKQ0KK3N0YXRpYyBpbnQgZ2V0aWZhY2VzKGNvbnN0
IGludCBzb2NrZmQsIGNoYXIgKioqbGlzdCwgaW50ICpsZW5ndGgpDQogew0K
ICNpZmRlZiBIQVZFX0lGTkFNRUlOREVYDQogICAgICAgc3RydWN0IGlmX25h
bWVpbmRleCAqaWZzdGFydCwgKmlmczsNCiAgICAgICBpbnQgaSA9IDA7DQor
CSAgY2hhciAqKm5ldzsNCiAgIA0KLSAgICAgIGlmICghbGlzdCB8fCAqbGVu
Z3RoIDwgMSkgDQotCXJldHVybiAwOw0KLQ0KICAgICAgIGlmcyA9IGlmc3Rh
cnQgPSBpZl9uYW1laW5kZXgoKTsNCisNCisJICBuZXcgPSAoY2hhciAqKikg
bWFsbG9jKChzaXplb2YoaWZzKS9zaXplb2Yoc3RydWN0IGlmX25hbWVpbmRl
eCkgKyAxKSAqIHNpemVvZihjaGFyICopKTsNCiAgICAgICB3aGlsZSAoaWZz
ICYmIGlmcy0+aWZfbmFtZSkgew0KIAkvKiBqdXN0IGJhaWwgaWYgdGhlcmUn
cyBhIHByb2JsZW0gKi8NCi0JaWYgKGFkZG5hbWUobGlzdCwgJmksIGxlbmd0
aCwgaWZzLT5pZl9uYW1lKSA8IDApDQorCWlmIChhZGRuYW1lKG5ldywgJmks
IGxlbmd0aCwgaWZzLT5pZl9uYW1lKSA8IDApDQogCSAgYnJlYWs7DQogCWlm
cysrOw0KICAgICAgIH0NCiANCiAgICAgICBpZl9mcmVlbmFtZWluZGV4KGlm
c3RhcnQpOw0KKwkgICpsaXN0ID0gbmV3Ow0KICAgICAgIHJldHVybiBpOw0K
IA0KICNlbHNlDQogICAgIHN0cnVjdCBpZmNvbmYJaWZjOw0KICAgICBzdHJ1
Y3QgaWZyZXEJaWZyc1sgNjQgXSwgKmlmciwgKm5leHRpZnI7DQogICAgIGlu
dAkJCWlmcnNpemUsIGkgPSAwOw0KKwljaGFyICoqbmV3Ow0KIA0KICAgICBp
ZiAoIWxpc3QgfHwgKmxlbmd0aCA8IDEpDQogICAgICAgcmV0dXJuIDA7DQpA
QCAtOTYsNiArOTEsNyBAQA0KIAlyZXR1cm4gMDsNCiAgICAgfQ0KIA0KKwlu
ZXcgPSAoY2hhciAqKikgbWFsbG9jKChpZmMuaWZjX2xlbi9zaXplb2Yoc3Ry
dWN0IGlmcmVxKSArIDEpICogc2l6ZW9mKGNoYXIgKikpOw0KICAgICBmb3Ig
KCBpZnIgPSBpZmMuaWZjX3JlcTsgaWZjLmlmY19sZW4gPj0gc2l6ZW9mKCBz
dHJ1Y3QgaWZyZXEgKTsNCiAJICAgIGlmYy5pZmNfbGVuIC09IGlmcnNpemUs
IGlmciA9IG5leHRpZnIgKSB7DQogI2lmZGVmIEJTRDRfNA0KQEAgLTEwOCw5
ICsxMDQsMTAgQEANCiAJbmV4dGlmciA9IChzdHJ1Y3QgaWZyZXEgKikoKGNh
ZGRyX3QpaWZyICsgaWZyc2l6ZSApOw0KIA0KIAkvKiBqdXN0IGJhaWwgaWYg
dGhlcmUncyBhIHByb2JsZW0gKi8NCi0JaWYgKGFkZG5hbWUobGlzdCwgJmks
IGxlbmd0aCwgaWZyLT5pZnJfbmFtZSkgPCAwKQ0KKwlpZiAoYWRkbmFtZShu
ZXcsICZpLCBsZW5ndGgsIGlmci0+aWZyX25hbWUpIDwgMCkNCiAJICBicmVh
azsNCiAgICAgfQ0KKwkqbGlzdCA9IG5ldzsNCiAgICAgcmV0dXJuIGk7DQog
I2VuZGlmDQogfQ0KQEAgLTEyMiwxNyArMTE5LDE0IEBADQogICovDQogY2hh
ciAqKmdldGlmYWNlbGlzdCgpDQogew0KLSAgY2hhciAqKmxpc3QgPSAoY2hh
ciAqKikgbWFsbG9jKHNpemVvZihjaGFyICoqKSooSUZBQ0VfTlVNICsgMSkp
Ow0KKyAgY2hhciAqKmxpc3Q7DQogICBjaGFyICoqbmV3Ow0KLSAgaW50IGxl
bmd0aCA9IElGQUNFX05VTSwgaSwgZmQ7DQorICBpbnQgIGxlbmd0aCwgaSwg
ZmQ7DQogDQotICBpZiAoIWxpc3QpDQotICAgIHJldHVybiBOVUxMOw0KLSAg
ICAgIA0KICAgaWYgKChmZCA9IHNvY2tldChQRl9JTkVULCBTT0NLX1NUUkVB
TSwgMCkpIDwgMCkNCiAgICAgcmV0dXJuIE5VTEw7DQogDQotICBpZiAoKGkg
PSBnZXRpZmFjZXMoZmQsIGxpc3QsICZsZW5ndGgpKSA9PSAwKSB7DQorICBp
ZiAoKGkgPSBnZXRpZmFjZXMoZmQsICZsaXN0LCAmbGVuZ3RoKSkgPT0gMCkg
ew0KICAgICBmcmVlKGxpc3QpOw0KICAgICBjbG9zZShmZCk7DQogICAgIHJl
dHVybiBOVUxMOw0KQEAgLTE0MCw3ICsxMzQsNyBAQA0KICAgY2xvc2UoZmQp
Ow0KIA0KICAgaWYgKChpIDwgbGVuZ3RoKSAmJiANCi0gICAgICAobmV3ID0g
KGNoYXIgKiopIHJlYWxsb2MobGlzdCwgc2l6ZW9mKGNoYXIgKiopKihpICsg
MSkpKSkNCisgICAgICAobmV3ID0gKGNoYXIgKiopIHJlYWxsb2MobGlzdCwg
KGkgKyAxKSAqICBzaXplb2YoY2hhciAqKSkpKQ0KICAgICByZXR1cm4gbmV3
Ow0KIA0KICAgcmV0dXJuIGxpc3Q7DQo=
--0-1360250229-1000394922=:4778--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010913111355.W4778-200000>