Date: Fri, 14 Sep 2001 12:34:54 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: "Andrew R. Reiter" <arr@watson.org> Cc: freebsd-audit@FreeBSD.ORG Subject: Re: dungeon master patch Message-ID: <20010914123454.B82568@sunbay.com> In-Reply-To: <20010914122614.A82568@sunbay.com>; from ru@FreeBSD.org on Fri, Sep 14, 2001 at 12:26:14PM %2B0300 References: <Pine.NEB.3.96L.1010914000517.11262A-200000@fledge.watson.org> <20010914122614.A82568@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 14, 2001 at 12:26:14PM +0300, Ruslan Ermilov wrote:
[...]
> > switch(*lbuf) {
> > case 'b': /* badtty */
> > - if (sscanf(lbuf, "%s%s", f1, f2) != 2 ||
> > + if (sscanf(lbuf, "%39s%39s", f1, f2) != 2 ||
>
> Use "%.s" and "sizeof(f1) - 1", don't hardcode.
>
Ahh, this isn't the printf(3), sorry.
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010914123454.B82568>