Date: Sun, 28 Oct 2001 22:26:56 -0700 From: Warner Losh <imp@harmony.village.org> To: Greg Lehey <grog@FreeBSD.org> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, mjacob@feral.com, Jonathan Lemon <jlemon@flugsvamp.com>, "Andrey A. Chernov" <ache@nagual.pp.ru>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) Message-ID: <200110290526.f9T5Qu785716@harmony.village.org> In-Reply-To: Your message of "Sun, 28 Oct 2001 19:02:25 %2B1030." <20011028190225.A88146@monorchid.lemis.com> References: <20011028190225.A88146@monorchid.lemis.com> <20011028085000.O8085@wantadilla.lemis.com> <31408.1004257724@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011028190225.A88146@monorchid.lemis.com> Greg Lehey writes: : On Sunday, 28 October 2001 at 9:28:44 +0100, Poul-Henning Kamp wrote: : > In message <20011028085000.O8085@wantadilla.lemis.com>, Greg Lehey writes: : > : >> I can't be bothered looking for a rule that says you shouldn't commit : >> anything which will knowingly cause breakage, but if it's not in the : >> book, it should be. First ensure that cause of the breakage gets : >> fixed, or fix it yourself. : > : > The kernel itself has been whining at making this mistake since : > 11 sep 2000. : > : > That should be more than sufficient warning for anyone. : : So why haven't you fixed it? : : Seriously, though, you've got to admit that's rather irrelevant to the : statement. Ummm, maybe he doesn't have hardware? Maybe driver authors have been doing it wrong alll along and they've been lucky? Come on Greg, I think you are going head to head with phk here over him doing the right thing. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110290526.f9T5Qu785716>