Date: Tue, 27 Nov 2001 16:55:07 -0500 From: Mike Barcroft <mike@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Committer's guide policy on commit message contents Message-ID: <20011127165507.B12400@espresso.q9media.com> In-Reply-To: <Pine.NEB.3.96L.1011127163632.20120A-100000@fledge.watson.org>; from rwatson@FreeBSD.org on Tue, Nov 27, 2001 at 04:37:49PM -0500 References: <20011127163513.A12400@espresso.q9media.com> <Pine.NEB.3.96L.1011127163632.20120A-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson <rwatson@FreeBSD.org> writes: > On Tue, 27 Nov 2001, Mike Barcroft wrote: > > > From the Committers Guide: "Do not waste space in the commit messages > > explaining what you did. That is what cvs diff is for. Instead, tell > > us why you did it." > > Ignoring, for a moment, any context -- I think this is actually not a good > policy. In the event that there are complex or large changes being made, > a brief summary of the changes, along with the rationale, is appropriate > in the commit message. At least, that's my feeling :-). Is this > something that would be worth changing? I completely agree. The main intent of my message was to point out the absurdity of following this rule. If commit messages did indeed only answer the why, they would be very cryptic. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011127165507.B12400>