Date: Tue, 27 Nov 2001 11:47:36 -0800 From: bmah@packetdesign.com (Bruce A. Mah) To: freebsd-net@freebsd.org Cc: bmah@packetdesign.com Subject: RFC: MFC M_ZERO usage for bpf.c Message-ID: <200111271947.fARJlaq00597@nimitz.packetdesign.com>
next in thread | raw e-mail | index | archive | help
--==_Exmh_1865514496P
Content-Type: text/plain; charset=us-ascii
Hi--
I've been reading through src/sys/net/bpf.c, and I noticed that the
changes to make it use M_ZERO haven't been MFC-ed to RELENG_4 yet. Any
objection if I do this? (Nothing broke in my quick testing.)
Thanks,
Bruce.
Index: bpf.c
===================================================================
RCS file: /usr/ncvs/src/sys/net/bpf.c,v
retrieving revision 1.59.2.6
diff -u -r1.59.2.6 bpf.c
--- bpf.c 20 Sep 2001 14:31:33 -0000 1.59.2.6
+++ bpf.c 27 Nov 2001 18:49:45 -0000
@@ -358,8 +358,7 @@
if (d)
return (EBUSY);
make_dev(&bpf_cdevsw, minor(dev), 0, 0, 0600, "bpf%d", lminor(dev));
- MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK);
- bzero(d, sizeof(*d));
+ MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK | M_ZERO);
dev->si_drv1 = d;
d->bd_bufsize = bpf_bufsize;
d->bd_sig = SIGIO;
@@ -1285,11 +1284,10 @@
u_int dlt, hdrlen;
{
struct bpf_if *bp;
- bp = (struct bpf_if *)malloc(sizeof(*bp), M_BPF, M_DONTWAIT);
+ bp = (struct bpf_if *)malloc(sizeof(*bp), M_BPF, M_DONTWAIT | M_ZERO);
if (bp == 0)
panic("bpfattach");
- bp->bif_dlist = 0;
bp->bif_ifp = ifp;
bp->bif_dlt = dlt;
--==_Exmh_1865514496P
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: Exmh on FreeBSD
iD8DBQE8A+3Y2MoxcVugUsMRAl5/AJwOOfK4eWs8cBXCCssGhHoL0EXiKACgsgKO
GAWQ29KVho5yzajShM5Jrio=
=OroY
-----END PGP SIGNATURE-----
--==_Exmh_1865514496P--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111271947.fARJlaq00597>