Date: Tue, 4 Dec 2001 14:37:30 -0700 From: "Kenneth D. Merry" <ken@kdm.org> To: Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de> Cc: freebsd-scsi@FreeBSD.ORG Subject: Re: camcontrol defects still broken Message-ID: <20011204143729.A73777@panzer.kdm.org> In-Reply-To: <20011204220732.H849@uriah.heep.sax.de>; from j@uriah.heep.sax.de on Tue, Dec 04, 2001 at 10:07:32PM %2B0100 References: <20011204220732.H849@uriah.heep.sax.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Tue, Dec 04, 2001 at 22:07:32 +0100, Joerg Wunsch wrote:
> Since i recently had enough time to upgrade to -current finally again,
> i'm now sure there's still a bug here:
>
> uriah # camcontrol defects da0 -P -f bfi -v
> camcontrol: Error returned from read defect data command
> (pass0:sym0:0:0:0): READ DEFECT DATA(10). CDB: 37 0 14 0 0 0 0 fd e8 0
> (pass0:sym0:0:0:0): CAM Status: CCB request completed without error
>
> I've seen this before on a number of -current systems, but they all
> weren't what i thought to be representative, so i wasn't certain it's
> actually a bug in camcontrol. Now with my main machine and a -current
> as of last week, i am ;-)
>
> This happens for whatever combination of arguments i'm using (-P or
> -G, -f bfi, -f phys or -f block), regardless of which disk i'm testing
> it against:
>
> uriah # foreach mode (-G -P)
> foreach? foreach fmt (block bfi phys)
> foreach? foreach dev (0 1 2)
> foreach? camcontrol defects da$dev -f $fmt $mode
> foreach? end
> foreach? end
> foreach? end
> camcontrol: Error returned from read defect data command
> [etc. pp.]
>
> All three disks are fairly modern disks that used to support this
> feature in the past.
This looks like a brain-o that went in with the error recovery changes last
March.
Try this patch and see if it works for you. (I haven't tested it.)
Ken
--
Kenneth Merry
ken@kdm.org
--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="camcontrol.c.readdefects.20011204"
==== //depot/FreeBSD-ken/src/sbin/camcontrol/camcontrol.c#18 - /usr/home/ken/perforce/FreeBSD-ken/src/sbin/camcontrol/camcontrol.c ====
*** /tmp/tmp.720.0 Tue Dec 4 14:35:25 2001
--- /usr/home/ken/perforce/FreeBSD-ken/src/sbin/camcontrol/camcontrol.c Tue Dec 4 14:33:37 2001
***************
*** 1291,1297 ****
CAM_EPF_ALL, stderr);
goto defect_bailout;
}
! } else {
error = 1;
warnx("Error returned from read defect data command");
if (arglist & CAM_ARG_VERBOSE)
--- 1291,1297 ----
CAM_EPF_ALL, stderr);
goto defect_bailout;
}
! } else if ((ccb->ccb_h.status & CAM_STATUS_MASK) != CAM_REQ_CMP) {
error = 1;
warnx("Error returned from read defect data command");
if (arglist & CAM_ARG_VERBOSE)
--XsQoSWH+UP9D9v3l--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011204143729.A73777>