Date: Thu, 20 Dec 2001 19:36:18 +0100 From: Joerg Wunsch <j@uriah.heep.sax.de> To: Bruce Evans <bde@zeta.org.au> Cc: Ruslan Ermilov <ru@FreeBSD.org>, developers@FreeBSD.org, arch@FreeBSD.org Subject: Re: cvs commit: src/sys/isa fd.c Message-ID: <20011220193618.B19756@uriah.heep.sax.de> In-Reply-To: <20011220235518.V673-100000@gamplex.bde.org>; from bde@zeta.org.au on Fri, Dec 21, 2001 at 12:11:13AM %2B1100 References: <20011219095119.B93645@sunbay.com> <20011220235518.V673-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
As Bruce Evans wrote: > > This is because _MACHINE_ARCH is a bogus define. > > True. It doesn't seem to be used for anything except to break > netgraph/ng_vjc.c in the same way as fd.c ... > > Then, the #if _MACHINE_ARCH == i386 becomes #if 1 == 1. > > Actually, it becomes `#if 0 == 0' 8-8. Then i vote to either drop the macros _MACHINE and _MACHINE_ARCH completely from /sys/*/include/param.h, or to provide a set of unique constants they will be defined to so they can actually be used in cpp comparisions. What does NetBSD do here? It would surprise me if they didn't have a method to distinguish between their various machines at the cpp level. -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011220193618.B19756>