Date: Thu, 31 Jan 2002 23:38:58 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "M. Warner Losh" <imp@village.org> Cc: <drosih@rpi.edu>, <deatley@apple.com>, <arch@FreeBSD.ORG> Subject: Re: __P macro question Message-ID: <20020131231008.P4085-100000@gamplex.bde.org> In-Reply-To: <20020130.145424.00452635.imp@village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 30 Jan 2002, M. Warner Losh wrote: > I'm going through bin right now removing __P() and making the > functions have new-style rather than old-style decls. It is a nice > little mindless thing to do when to relax and unwind. I plan on > committing this this weekend (see below). I've seen nothing so far to > tell me not to do it: Don't do it all. Some people prefer old-style decls, and unlike __P(()), they don't involve any preprocessor hackery; they are part of ISO C. Kirks' mail to OpenBSD explicitly said that changing the decls is not being considered now: % > In message <200201310328.g0V3Sci74844@beastie.mckusick.com> % so spake Kirk McKusick (mckusick): % > FreeBSD's current policy is also not to use __P(()) in new code. % > The current proposal is to simply remove the __P(()), not to convert % > the function headers (which may be a reasonable thing to do, but is % > not part of the current plan). When removing __P(()), don't do it like login/login.c rev.1.80: - mix the removal with nontrivial rewriting of the code to make it harder for auditors to see the critical changes. Change all the function headers too, but don't de-verbosify the code by removing the prototypes made redundant by this. - be sure to unsort the prototypes and add excessive indentation to them. Using a low quality script to regenerate all the prototypes is a good way to do this. ;-) Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020131231008.P4085-100000>