Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Feb 2002 16:26:48 -0500
From:      Andrew Gallatin <gallatin@cs.duke.edu>
To:        Max Khon <fjoe@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/net if.c if_arc.h if_arp.h if_ethersubr.c if_fddisubr.c if_iso88025subr.c if_var.h if_vlan.c src/sys/netinet if_ether.c if_ether.h
Message-ID:  <20020219162648.A52559@grasshopper.cs.duke.edu>
In-Reply-To: <200202132138.g1DLcuB88159@freefall.freebsd.org>; from fjoe@FreeBSD.org on Wed, Feb 13, 2002 at 01:38:56PM -0800
References:  <200202132138.g1DLcuB88159@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Max Khon [fjoe@FreeBSD.org] wrote:
> fjoe        2002/02/13 13:38:56 PST
<...>
>   Log:
>   MFC: ARP support for variable length link level addresses

<...>
>   1.18.2.13  +4 -0      src/sys/net/if_var.h

The addition of a pointer ( u_int8_t *if_broadcastaddr;) into struct
ifnet breaks binary compatability in the 4-stable series for 3rd party
network drivers by moving the ac_enaddr[] field down in struct arpcom.

Eg, for a binary module compiled on 4.1.1 (which worked fine up to
now) I now see this:

myri0: flags=843<UP,BROADCAST,RUNNING,SIMPLEX> mtu 9000
       inet 192.168.1.4 netmask 0xffffff00 broadcast 192.168.1.255
       ether 57:98:00:00:00:00 


When I should see this:

myri0: flags=843<UP,BROADCAST,RUNNING,SIMPLEX> mtu 9000
       inet 192.168.1.4 netmask 0xffffff00 broadcast 192.168.1.255
       ether 00:60:dd:7f:57:98 

Note the mac address is shifted over by the size of a pointer.

I'd greatly appreciate it if you could find somewhere else to put
this pointer that does not break binary compatbility.

Thanks!

Drew
(Wearing his Myricom Inc. hat).


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020219162648.A52559>