Date: Wed, 27 Feb 2002 18:57:27 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "M. Warner Losh" <imp@village.org> Cc: <mike@FreeBSD.ORG>, <standards@FreeBSD.ORG> Subject: Re: Garrett's POSIX versions patch for review Message-ID: <20020227184645.K47808-100000@gamplex.bde.org> In-Reply-To: <20020226.224449.28794535.imp@village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 26 Feb 2002, M. Warner Losh wrote: > I think that these diffs look good on the surface. I agree that it > would be nice to have a prisitine c99 env, but if that's hard to do, > then I don't see waiting the rest of the changes. I think they look bad on the surface :-). E.g., using #if defined (...) instead of #ifdef, and indenting preprocessor code are style bugs. There are superflous underscores. I don't remember any technical problems from when I reviewed the first version of Garrett's patch. The new __FOO_VISIBLE macros are much easier to use than the old _FOO_VISIBLE[_BAR] ones. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020227184645.K47808-100000>