Date: Thu, 07 Mar 2002 12:06:49 +0000 From: Mark Murray <mark@grondar.za> To: obrien@FreeBSD.org Cc: Will Andrews <will@csociety.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <200203071206.g27C6nRV009991@grimreaper.grondar.org> In-Reply-To: <20020307032014.B63863@dragon.nuxi.com> ; from "David O'Brien" <obrien@FreeBSD.org> "Thu, 07 Mar 2002 03:20:14 PST." References: <20020307032014.B63863@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > In my opinion, the above change makes the code clearer. The > > previous construct obfuscates the logic. > > 1. that is not sufficient reason to arbitrarily change working code. Content free statement. Taking this stament seriously means clarifying code is not possible. > 2. please review the C idiom of short-circuit evaluation. I know this. See style(9) on complicated expressions. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203071206.g27C6nRV009991>