Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Mar 2002 15:13:33 -0800
From:      David O'Brien <obrien@FreeBSD.ORG>
To:        Mark Murray <mark@grondar.za>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/bin/dd args.c dd.c dd.h
Message-ID:  <20020307151333.A72218@hub.freebsd.org>
In-Reply-To: <200203071216.g27CGMRV010209@grimreaper.grondar.org>; from mark@grondar.za on Thu, Mar 07, 2002 at 12:16:22PM %2B0000
References:  <20020307035232.A67494@hub.freebsd.org> <200203071216.g27CGMRV010209@grimreaper.grondar.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 07, 2002 at 12:16:22PM +0000, Mark Murray wrote:
> 
> You wanna see my warning-and-error-suppression list?
> 
> Please do not assume that a) I am doing this mechanically, or b) that I
> am anally "fixing" every warning that I see.

I have looked closer at many of your WARNS/lint(1) fixes.  A lot of them
are very good.  Your adding const in prototypes and to string vars, and
changing some `int' definitions to `u_int' (I don't care about the
spelling of unsigned int) are good.  As is making more functions static.
These changes are hard to have problems with.

Is it possible to maybe commit WARNS/lint fixes in stages -- first the
total no brainers, and later those that might have more controversy?

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307151333.A72218>