Date: Mon, 18 Mar 2002 10:34:23 -0500 (EST) From: Mikhail Teterin <mi@aldan.algebra.com> To: roam@ringlet.net Cc: imp@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/xtend user.c xtend.c Message-ID: <200203181534.g2IFYN3b020895@aldan.algebra.com> In-Reply-To: <20020318141639.B1326@straylight.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 Mar, Peter Pentchev wrote: > On Sun, Mar 17, 2002 at 11:14:59PM -0800, Warner Losh wrote: >> imp 2002/03/17 23:14:59 PST >> >> Modified files: >> libexec/xtend user.c xtend.c >> Log: >> o MAXPATHLEN is the correct constant to use for path names, it includes >> the NULL. >> o use snprintf in preference to unchecked strcat in a couple of places that >> likely can't overflow. Makes it easier to grep for strcpy :-) > > /me sprinkles some magic comma dust over the naughty-naughty imp :) > [IOW, please try the attached patch :] Since the X10DIR and X10DUMPNAME are both known at compile time, why not - snprintf(dumppath, sizeof(dumppath), "%s/%s", X10DIR, X10DUMPNAME); + strncpy(dumppath, X10DIR "/" X10DUMPNAME, sizeof(dumppath)); and so on? (The plain strcpy would do just fine here too, IMO :) -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203181534.g2IFYN3b020895>